From: Antti Palosaari <crope@iki.fi>
To: Thomas Mair <thomas.mair86@googlemail.com>
Cc: pomidorabelisima@gmail.com,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH v4 0/5] support for rtl2832
Date: Thu, 17 May 2012 17:53:41 +0300 [thread overview]
Message-ID: <4FB510F5.4090902@iki.fi> (raw)
In-Reply-To: <1337206420-23810-1-git-send-email-thomas.mair86@googlemail.com>
On 17.05.2012 01:13, Thomas Mair wrote:
> This is the new version of the patch series to add support for the
> rtl2832 demodulator driver. Before applying the patches you need to
> add the fc0012/fc0013 driver from Hans-Frider Vogt.
Who wants to review those tuner drivers?
> The changes from the privious version of the patches are manly in the
> rtl2832 demod driver to fix code style issues, a nasty bug in the
> frontends Makefile and the removal of the signal statistics functionality
> which was badly broken in version 0.3 of the driver.
>
> The one thing that I am not really confident with is the Kconfig file for
> the dvb frontend driver. Are the changes I made right? And if not what
> kind of changes need to be made?
>
> Thanks Antti and poma for your comments!
I have reviewed all patches and commented some issues. Those are after
all relative small issues you can sent just new patch top of that to fix
or rebase whole patch series and sent new. It is up to you.
regards
Antti
>
> Regards
> Thomas
>
> Thomas Mair (5):
> rtl2832 ver. 0.4: removed signal statistics
> rtl28xxu: support for the rtl2832 demod driver
> rtl28xxu: renamed rtl2831_rd/rtl2831_wr to rtl28xx_rd/rtl28xx_wr
> rtl28xxu: support G-Tek Electronics Group Lifeview LV5TDLX DVB-T
> rtl28xxu: support Terratec Noxon DAB/DAB+ stick
>
> drivers/media/dvb/dvb-usb/Kconfig | 3 +
> drivers/media/dvb/dvb-usb/dvb-usb-ids.h | 3 +
> drivers/media/dvb/dvb-usb/rtl28xxu.c | 513 ++++++++++++++++--
> drivers/media/dvb/frontends/Kconfig | 7 +
> drivers/media/dvb/frontends/Makefile | 1 +
> drivers/media/dvb/frontends/rtl2832.c | 825 ++++++++++++++++++++++++++++
> drivers/media/dvb/frontends/rtl2832.h | 74 +++
> drivers/media/dvb/frontends/rtl2832_priv.h | 258 +++++++++
> 8 files changed, 1636 insertions(+), 48 deletions(-)
> create mode 100644 drivers/media/dvb/frontends/rtl2832.c
> create mode 100644 drivers/media/dvb/frontends/rtl2832.h
> create mode 100644 drivers/media/dvb/frontends/rtl2832_priv.h
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2012-05-17 14:53 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1>
2012-05-16 22:13 ` [PATCH v4 0/5] support for rtl2832 Thomas Mair
2012-05-16 22:13 ` [PATCH v4 1/5] rtl2832 ver. 0.4: removed signal statistics Thomas Mair
2012-05-17 3:36 ` poma
2012-05-17 3:40 ` poma
2012-05-17 8:04 ` Thomas Mair
2012-05-17 14:19 ` Antti Palosaari
2012-05-17 20:27 ` poma
2012-05-17 20:41 ` Antti Palosaari
2012-05-17 20:45 ` Thomas Mair
2012-05-17 20:49 ` Antti Palosaari
2012-05-17 21:03 ` poma
2012-05-17 21:08 ` poma
2012-05-17 21:19 ` Thomas Mair
2012-05-17 21:30 ` poma
2012-05-18 0:55 ` poma
[not found] ` <CAKZ=SG_mvvFae9ZE2H3ci_3HosLmQ1kihyGx6QCdyQGgQro52Q@mail.gmail.com>
2012-05-18 9:15 ` poma
2012-05-18 10:38 ` poma
2012-05-18 12:38 ` Antti Palosaari
2012-05-18 13:26 ` poma
2012-05-18 17:46 ` Thomas Mair
2012-05-18 17:51 ` Antti Palosaari
2012-05-16 22:13 ` [PATCH v4 2/5] rtl28xxu: support for the rtl2832 demod driver Thomas Mair
2012-05-17 14:41 ` Antti Palosaari
2012-05-16 22:13 ` [PATCH v4 3/5] rtl28xxu: renamed rtl2831_rd/rtl2831_wr to rtl28xx_rd/rtl28xx_wr Thomas Mair
2012-05-17 14:43 ` Antti Palosaari
2012-05-16 22:13 ` [PATCH v4 4/5] rtl28xxu: support G-Tek Electronics Group Lifeview LV5TDLX DVB-T Thomas Mair
2012-05-17 14:47 ` Antti Palosaari
2012-05-17 20:43 ` poma
2012-05-16 22:13 ` [PATCH v4 5/5] rtl28xxu: support Terratec Noxon DAB/DAB+ stick Thomas Mair
2012-05-17 14:50 ` Antti Palosaari
2012-05-17 14:53 ` Antti Palosaari [this message]
2012-05-18 18:47 ` [PATCH v5 0/5] support for rtl2832 Thomas Mair
2012-05-18 18:47 ` [PATCH v5 1/5] rtl2832 ver. 0.5: support for RTL2832 demod Thomas Mair
2012-05-18 20:21 ` Antti Palosaari
2012-07-05 14:32 ` Mauro Carvalho Chehab
2012-07-05 14:35 ` Antti Palosaari
2012-07-05 15:54 ` Mauro Carvalho Chehab
2012-07-07 15:45 ` poma
2012-07-05 14:41 ` Antti Palosaari
2012-07-05 15:53 ` Mauro Carvalho Chehab
2012-05-18 18:47 ` [PATCH v5 2/5] rtl28xxu: support for the rtl2832 demod driver Thomas Mair
2012-05-18 20:28 ` Antti Palosaari
2012-05-18 18:47 ` [PATCH v5 3/5] rtl28xxu: renamed rtl2831_rd/rtl2831_wr to rtl28xx_rd/rtl28xx_wr Thomas Mair
2012-05-18 20:30 ` Antti Palosaari
2012-05-18 18:47 ` [PATCH v5 4/5] rtl28xxu: support Delock USB 2.0 DVB-T Thomas Mair
2012-05-18 20:31 ` Antti Palosaari
2012-05-18 18:47 ` [PATCH v5 5/5] rtl28xxu: support Terratec Noxon DAB/DAB+ stick Thomas Mair
2012-05-18 20:32 ` Antti Palosaari
2012-05-18 20:47 ` [PATCH v5 0/5] support for rtl2832 Antti Palosaari
2012-05-18 23:35 ` poma
2012-05-20 9:56 ` Thomas Mair
2012-05-20 10:14 ` Antti Palosaari
2012-05-18 23:39 ` poma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB510F5.4090902@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=pomidorabelisima@gmail.com \
--cc=thomas.mair86@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).