From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:2085 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913Ab2ETNc2 (ORCPT ); Sun, 20 May 2012 09:32:28 -0400 Message-ID: <4FB8F266.7050308@redhat.com> Date: Sun, 20 May 2012 10:32:22 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Devin Heitmueller CC: Ismael Luceno , linux-media@vger.kernel.org Subject: Re: [PATCH 2/2] au0828: Move under dvb References: <1336716892-5446-1-git-send-email-ismael.luceno@gmail.com> <1336716892-5446-2-git-send-email-ismael.luceno@gmail.com> <20120512000858.3d9e41a8@pirotess> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em 12-05-2012 07:21, Devin Heitmueller escreveu: > On Fri, May 11, 2012 at 11:08 PM, Ismael Luceno wrote: >> On Fri, 11 May 2012 08:04:59 -0400 >> Devin Heitmueller wrote: >> ... >>> What is the motivation for moving these files? >> >> Well, the device was on the wrong Kconfig section, and while thinking >> about changing that, I just thought to move it under DVB. >> >>> The au0828 is a hybrid bridge, and every other hybrid bridge is >>> under video? >> >> Sorry, the devices I got don't support analog, so I didn't thought >> about it that much... >> >> I guess it's arbitrary... isn't it? wouldn't it be better to have an >> hybrid section? (just thinking out loud) > > Yeah, in this case it's largely historical (a product from before the > V4L and DVB subsystems were merged). At this point I don't see any > real advantage to arbitrarily moving the stuff around. And in fact in > some areas it's even more ambiguous because some drivers are hybrid > drivers but support both hybrid chips as well as analog-only (the > em28xx driver is one such example). > > Anyway, Mauro is welcome to offer his opinion if it differs, but as > far as I'm concerned this patch shouldn't get applied. I won't apply this patch. If the Kconfig menus are confusing, then we should fix it, instead of moving things from one place to another ;) > > Cheers, > > Devin >