From: Sylwester Nawrocki <snjw23@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-media@vger.kernel.org, s.nawrocki@samsung.com,
mchehab@infradead.org, patches@linaro.org
Subject: Re: [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file
Date: Sat, 26 May 2012 10:39:50 +0200 [thread overview]
Message-ID: <4FC096D6.3040504@gmail.com> (raw)
In-Reply-To: <1337967533-22240-1-git-send-email-sachin.kamat@linaro.org>
Hi Sachin,
On 05/25/2012 07:38 PM, Sachin Kamat wrote:
> Fixes the following sparse warning:
> drivers/media/video/s5p-fimc/fimc-lite-reg.c:218:6: warning: symbol
> 'flite_hw_set_out_order' was not declared. Should it be static?
Thanks for the patches. However I'm inclined to squash this whole
series into one patch, since it addresses same issue in one driver,
just in different. I don't see a good reason to split those changes
like this. Could you make it just one patch instead ?
Regards,
Sylwester
next prev parent reply other threads:[~2012-05-26 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 17:38 [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file Sachin Kamat
2012-05-25 17:38 ` [PATCH 2/4] [media] s5p-fimc: Add missing static storage class in fimc-mdevice.c file Sachin Kamat
2012-05-25 17:38 ` [PATCH 3/4] [media] s5p-fimc: Add missing static storage class in fimc-core.c file Sachin Kamat
2012-05-25 17:38 ` [PATCH 4/4] [media] s5p-fimc: Add missing static storage class in fimc-capture.c file Sachin Kamat
2012-05-26 8:39 ` Sylwester Nawrocki [this message]
2012-05-26 14:55 ` [PATCH 1/4] [media] s5p-fimc: Add missing static storage class in fimc-lite-reg.c file Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC096D6.3040504@gmail.com \
--to=snjw23@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=patches@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox