From: Hans de Goede <hdegoede@redhat.com>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] gspca - ov534/ov534_9: Fix sccd_read/write errors
Date: Tue, 29 May 2012 11:15:09 +0200 [thread overview]
Message-ID: <4FC4939D.80601@redhat.com> (raw)
In-Reply-To: <20120528190407.463f7d6e@tele>
Hi,
Thanks I've added this and the sonixj fixes to my tree and send an
updated pullreq to Mauro to include these in the next round of
fixes for 3.5
Regards,
Hans
On 05/28/2012 07:04 PM, Jean-Francois Moine wrote:
> The ov534 bridge is too slow to handle the sensor accesses
> requested by fast hosts giving 'sccb_reg_write failed'.
> A small delay fixes the problem.
>
> Signed-off-by: Jean-François Moine<moinejf@free.fr>
> ---
> drivers/media/video/gspca/ov534.c | 1 +
> drivers/media/video/gspca/ov534_9.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/media/video/gspca/ov534.c b/drivers/media/video/gspca/ov534.c
> index b5acb1e..d5a7873 100644
> --- a/drivers/media/video/gspca/ov534.c
> +++ b/drivers/media/video/gspca/ov534.c
> @@ -851,6 +851,7 @@ static int sccb_check_status(struct gspca_dev *gspca_dev)
> int i;
>
> for (i = 0; i< 5; i++) {
> + msleep(10);
> data = ov534_reg_read(gspca_dev, OV534_REG_STATUS);
>
> switch (data) {
> diff --git a/drivers/media/video/gspca/ov534_9.c b/drivers/media/video/gspca/ov534_9.c
> index e6601b8..0120f94 100644
> --- a/drivers/media/video/gspca/ov534_9.c
> +++ b/drivers/media/video/gspca/ov534_9.c
> @@ -1008,6 +1008,7 @@ static int sccb_check_status(struct gspca_dev *gspca_dev)
> int i;
>
> for (i = 0; i< 5; i++) {
> + msleep(10);
> data = reg_r(gspca_dev, OV534_REG_STATUS);
>
> switch (data) {
prev parent reply other threads:[~2012-05-29 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 17:04 [PATCH] gspca - ov534/ov534_9: Fix sccd_read/write errors Jean-Francois Moine
2012-05-29 9:15 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC4939D.80601@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).