From: Michael Hunold <michael@mihu.de>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Peter Senna Tschudin <peter.senna@gmail.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 3/8] [RESEND] saa7146: Variable set but not used
Date: Fri, 15 Jun 2012 08:37:55 +0200 [thread overview]
Message-ID: <4FDAD843.8070108@mihu.de> (raw)
In-Reply-To: <4FDAD50D.1010903@xs4all.nl>
Hello Hans,
on 15.06.2012 08:24 Hans Verkuil said the following:
> On 15/06/12 08:02, Michael Hunold wrote:
>> A few lines below "fh" is allocated and "fh->type" is set to "type".
>> Simply removing "type" will result in a compilation error IMO, so I
>> wonder if your compile-test really worked.
>>
>> Can you have a look again?
> Are you perhaps looking at an older version of this source?
most likely. :-/
> 'fh->type'
> no longer exists.
> Anyway, this patch is correct.
Ok, then feel free to pick it. :-)
> Regards,
>
> Hans
Best regards
Michael.
next prev parent reply other threads:[~2012-06-15 6:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 17:58 [PATCH 1/8] [RESEND] cx231xx: Paranoic stack memory save Peter Senna Tschudin
2012-06-14 17:58 ` [PATCH 2/8] [RESEND] pvrusb2: Variables set but not used Peter Senna Tschudin
2012-06-14 17:58 ` [PATCH 3/8] [RESEND] saa7146: Variable " Peter Senna Tschudin
2012-06-15 6:02 ` Michael Hunold
2012-06-15 6:24 ` Hans Verkuil
2012-06-15 6:37 ` Michael Hunold [this message]
2012-06-14 17:58 ` [PATCH 4/8] [RESEND] saa7164: " Peter Senna Tschudin
2012-06-14 17:58 ` [PATCH 5/8] nuvoton-cir: Code cleanup: remove unused variable and function Peter Senna Tschudin
2012-06-14 19:02 ` Ben Hutchings
2012-06-15 13:26 ` Jarod Wilson
2012-06-14 17:58 ` [PATCH 6/8] stv0367: variable 'tps_rcvd' set but not used Peter Senna Tschudin
2012-06-14 17:58 ` [PATCH 7/8] stv090x: variable 'no_signal' " Peter Senna Tschudin
2012-06-14 17:58 ` [PATCH 8/8] s5h1420: Unused variable clock_setting Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDAD843.8070108@mihu.de \
--to=michael@mihu.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).