From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:29394 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808Ab2FRKu6 (ORCPT ); Mon, 18 Jun 2012 06:50:58 -0400 Message-ID: <4FDF07FB.1080802@redhat.com> Date: Mon, 18 Jun 2012 07:50:35 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Laurent Pinchart CC: Hans Verkuil , linux-media@vger.kernel.org, Mauro Carvalho Chehab , Hans de Goede , Andy Walls , Guennadi Liakhovetski , Pawel Osciak , Tomasz Stanislawski , Hans Verkuil Subject: Re: [RFCv1 PATCH 18/32] v4l2-ioctl.c: finalize table conversion. References: <1339323954-1404-1-git-send-email-hverkuil@xs4all.nl> <10390224.oHYD7VJvJs@avalon> In-Reply-To: <10390224.oHYD7VJvJs@avalon> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em 18-06-2012 06:46, Laurent Pinchart escreveu: > Hi Hans, > > Thanks for the patch. > > On Sunday 10 June 2012 12:25:40 Hans Verkuil wrote: >> From: Hans Verkuil >> >> Signed-off-by: Hans Verkuil >> --- >> drivers/media/video/v4l2-ioctl.c | 35 +++++++++++++---------------------- >> 1 file changed, 13 insertions(+), 22 deletions(-) >> >> diff --git a/drivers/media/video/v4l2-ioctl.c >> b/drivers/media/video/v4l2-ioctl.c index 0de31c4..6c91674 100644 >> --- a/drivers/media/video/v4l2-ioctl.c >> +++ b/drivers/media/video/v4l2-ioctl.c >> @@ -870,6 +870,11 @@ static void v4l_print_newline(const void *arg) >> pr_cont("\n"); >> } >> >> +static void v4l_print_default(const void *arg) >> +{ >> + pr_cont("non-standard ioctl\n"); > > I'd say "driver-specific ioctl" instead. "non-standard" may sound like an > error to users. This message is useless as-is, as it provides no glue about what ioctl was called. You should either remove it or print the ioctl number, in hexa. Regards, Mauro