From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37312 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754266Ab2F0NL1 (ORCPT ); Wed, 27 Jun 2012 09:11:27 -0400 Message-ID: <4FEB0664.3030408@redhat.com> Date: Wed, 27 Jun 2012 10:11:00 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Dan Carpenter CC: Mauro Carvalho Chehab , Jose Alberto Reguero , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch -resend] [media] az6007: precedence bug in az6007_i2c_xfer() References: <20120627090644.GP31212@elgon.mountain> In-Reply-To: <20120627090644.GP31212@elgon.mountain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em 27-06-2012 06:06, Dan Carpenter escreveu: > The intent here was to test that the flag was clear but the '!' has > higher precedence than the '&'. I2C_M_RD is 0x1 so the current code is > equivalent to "&& (!sgs[i].flags) ..." > > Signed-off-by: Dan Carpenter > --- > I sent this originally on Wed, 25 Jan 2012 and Emil Goode sent the same > fix on Thu, May 3, 2012. > > diff --git a/drivers/media/dvb/dvb-usb/az6007.c b/drivers/media/dvb/dvb-usb/az6007.c > index 4008b9c..f6f0cf9 100644 > --- a/drivers/media/dvb/dvb-usb/az6007.c > +++ b/drivers/media/dvb/dvb-usb/az6007.c > @@ -711,7 +711,7 @@ static int az6007_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], > addr = msgs[i].addr << 1; > if (((i + 1) < num) > && (msgs[i].len == 1) > - && (!msgs[i].flags & I2C_M_RD) > + && (!(msgs[i].flags & I2C_M_RD)) > && (msgs[i + 1].flags & I2C_M_RD) > && (msgs[i].addr == msgs[i + 1].addr)) { > /* > Dan, Your logic is correct, however, I didn't apply this patch because it broke the driver. I'll need to re-visit the driver when I have some time, in order to be able to apply this one, without breaking the driver. I'll likely need to change some other things on this routine. (this has a low priority, as the driver is working properly the way it is). So, I'm keeping your patch at patchwork, while I don't find some time for it. Regards, Mauro