Re: [PATCH 4/8] v4l: Common documentation for selection targets

[Sylwester Nawrocki <sylwester.nawrocki@gmail.com>]

On 06/30/2012 07:03 PM, Sakari Ailus wrote:
> Both V4L2 and V4L2 subdev interface have very similar selection APIs with
> differences foremost related to in-memory and media bus formats. However,
> the selection targets are the same for both. Most targets are and in the
> future will likely continue to be more the same than with any differences.
> Thus it makes sense to unify the documentation of the targets.
>
> Signed-off-by: Sakari Ailus<sakari.ailus@iki.fi>
> ---
..
> diff --git a/Documentation/DocBook/media/v4l/selections-common.xml b/Documentation/DocBook/media/v4l/selections-common.xml
> new file mode 100644
> index 0000000..d0411ab
> --- /dev/null
> +++ b/Documentation/DocBook/media/v4l/selections-common.xml
> @@ -0,0 +1,92 @@
> +<section id="v4l2-selections-common">
> +
> +<title>Selection targets</title>
> +
> +<para>While the<link linkend="selection-api">V4L2 selection
> +  API</link>  and<link linkend="v4l2-subdev-selections">V4L2 subdev
> +  selection APIs</link>  are very similar, there's one fundamental
> +  difference between the two. On sub-device API, the selection
> +  rectangle refers to the media bus format, and is bound to a
> +  sub-device's pad. On the V4L2 interface the selection rectangles
> +  refer to the in-memory pixel format.</para>
> +
> +<para>The precise meaning of the selection targets may thus be
> +  affected on which of the two interfaces they are used.</para>
> +
> +<table pgwide="1" frame="none" id="v4l2-selection-targets-table">
> +<title>Selection target definitions</title>
> +<tgroup cols="4">

s/4/5

Looks good otherwise.

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

 > +<colspec colname="c1" />
 > +<colspec colname="c2" />
 > +<colspec colname="c3" />
 > +<colspec colname="c4" />
 > +<colspec colname="c5" />
 > +&cs-def;
 > +<thead>