From: Thomas Betker <thomas.betker@freenet.de>
To: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org
Subject: [PATCH] bttv-cards.c: Allow radio for CHP05x/CHP06x.
Date: Sun, 01 Jul 2012 16:22:08 +0200 [thread overview]
Message-ID: <4FF05D10.1060906@freenet.de> (raw)
Add ".has_radio = 1" for BTTV_BOARD_MAGICTVIEW061 because there are
some CHP05x/CHP06x boards with a radio tuner.
I still have an analog Askey Magic TView card (CHP051, PCI 144f:3002)
which I use for radio only. This worked fine with kernel 2.6.37
(openSUSE 11.4), but no longer works with kernel 3.1.10 (openSUSE 12.1).
The reason apparently is that ".has_radio = 1" is missing in
bttv-cards.c for BTTV_BOARD_MAGICTVIEW061; when I add this line and
recompile the kernel, radio is working again. The line is still missing
in the latest git tree, for which I have generated the attached patch.
I can't test what will happen for CHP05x/CHP06x devices without radio;
however, it seems that other cards also have the problem that there are
some boards with radio and some without, so I hope that this can be
sorted out.
Signed-off-by: Thomas Betker <thomas.betker@freenet.de>
diff -Naur linux-HEAD-6887a41-orig/drivers/media/video/bt8xx/bttv-cards.c linux-HEAD-6887a41/drivers/media/video/bt8xx/bttv-cards.c
--- linux-HEAD-6887a41-orig/drivers/media/video/bt8xx/bttv-cards.c 2012-06-30 23:08:57.000000000 +0000
+++ linux-HEAD-6887a41/drivers/media/video/bt8xx/bttv-cards.c 2012-07-01 10:09:28.672559366 +0000
@@ -676,6 +676,7 @@
.tuner_type = UNSET,
.tuner_addr = ADDR_UNSET,
.has_remote = 1,
+ .has_radio = 1, /* not every card has radio */
},
[BTTV_BOARD_VOBIS_BOOSTAR] = {
.name = "Terratec TerraTV+ Version 1.0 (Bt848)/ Terra TValue Version 1.0/ Vobis TV-Boostar",
reply other threads:[~2012-07-01 14:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF05D10.1060906@freenet.de \
--to=thomas.betker@freenet.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).