From: Tomasz Stanislawski <t.stanislaws@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-media@vger.kernel.org, mchehab@infradead.org,
s.nawrocki@samsung.com, patches@linaro.org
Subject: Re: [PATCH 1/1] [media] s5p-tv: Use module_i2c_driver in sii9234_drv.c file
Date: Thu, 05 Jul 2012 10:47:37 +0200 [thread overview]
Message-ID: <4FF554A9.6070100@samsung.com> (raw)
In-Reply-To: <1341383595-4386-1-git-send-email-sachin.kamat@linaro.org>
Hi Sachin,
Thank you for the patch.
On 07/04/2012 08:33 AM, Sachin Kamat wrote:
> module_i2c_driver makes the code simpler by eliminating module_init
> and module_exit calls.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
> ---
> drivers/media/video/s5p-tv/sii9234_drv.c | 12 +-----------
> 1 files changed, 1 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/media/video/s5p-tv/sii9234_drv.c b/drivers/media/video/s5p-tv/sii9234_drv.c
> index 0f31ecc..6d348f9 100644
> --- a/drivers/media/video/s5p-tv/sii9234_drv.c
> +++ b/drivers/media/video/s5p-tv/sii9234_drv.c
> @@ -419,14 +419,4 @@ static struct i2c_driver sii9234_driver = {
> .id_table = sii9234_id,
> };
>
> -static int __init sii9234_init(void)
> -{
> - return i2c_add_driver(&sii9234_driver);
> -}
> -module_init(sii9234_init);
> -
> -static void __exit sii9234_exit(void)
> -{
> - i2c_del_driver(&sii9234_driver);
> -}
> -module_exit(sii9234_exit);
> +module_i2c_driver(sii9234_driver);
prev parent reply other threads:[~2012-07-05 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 6:33 [PATCH 1/1] [media] s5p-tv: Use module_i2c_driver in sii9234_drv.c file Sachin Kamat
2012-07-05 8:47 ` Tomasz Stanislawski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF554A9.6070100@samsung.com \
--to=t.stanislaws@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=patches@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).