From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:57998 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460Ab2GEOlR (ORCPT ); Thu, 5 Jul 2012 10:41:17 -0400 Message-ID: <4FF5A786.7020706@iki.fi> Date: Thu, 05 Jul 2012 17:41:10 +0300 From: Antti Palosaari MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: Thomas Mair , linux-media@vger.kernel.org, pomidorabelisima@gmail.com Subject: Re: [PATCH v5 1/5] rtl2832 ver. 0.5: support for RTL2832 demod References: <1> <1337366864-1256-1-git-send-email-thomas.mair86@googlemail.com> <1337366864-1256-2-git-send-email-thomas.mair86@googlemail.com> <4FF5A582.7070908@redhat.com> In-Reply-To: <4FF5A582.7070908@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 07/05/2012 05:32 PM, Mauro Carvalho Chehab wrote: > Em 18-05-2012 15:47, Thomas Mair escreveu: >> +static int rtl2832_read_signal_strength(struct dvb_frontend *fe, u16 *strength) >> +{ >> + *strength = 0; >> + return 0; >> +} > > Why to implement the above, if they're doing nothing? Other your findings were correct but for that I would like to comment. Have you ever tested what happens you lest those without stub implementation? IIRC ugly errors are seen for example zap and femon outputs. Some kind of DVB-core changes are needed. And IIRC there was some error code defined too for API - but such code does not exists. regards Antti -- http://palosaari.fi/