From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] em28xx: Remove useless runtime->private_data usage
Date: Thu, 05 Jul 2012 13:57:32 -0300 [thread overview]
Message-ID: <4FF5C77C.7030500@redhat.com> (raw)
In-Reply-To: <1339509222-2714-2-git-send-email-elezegarcia@gmail.com>
Em 12-06-2012 10:53, Ezequiel Garcia escreveu:
> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
> ---
> drivers/media/video/em28xx/em28xx-audio.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c
> index d7e2a3d..2fcddae 100644
> --- a/drivers/media/video/em28xx/em28xx-audio.c
> +++ b/drivers/media/video/em28xx/em28xx-audio.c
> @@ -305,7 +305,6 @@ static int snd_em28xx_capture_open(struct snd_pcm_substream *substream)
>
> snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS);
> dev->adev.capture_pcm_substream = substream;
> - runtime->private_data = dev;
Are you sure that this can be removed? I think this is used internally
by the alsa API, but maybe something has changed and this is not
required anymore.
Had you test em28xx audio with this change?
Regards,
Mauro
next prev parent reply other threads:[~2012-07-05 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 13:53 [PATCH] em28xx: Make a few drxk_config structs static Ezequiel Garcia
2012-06-12 13:53 ` [PATCH] em28xx: Remove useless runtime->private_data usage Ezequiel Garcia
2012-07-05 16:57 ` Mauro Carvalho Chehab [this message]
[not found] ` <CALF0-+XzNOiM+TA3rzY2NGSyXgFL8SuVU_yP0GTpcFMavQmNSg@mail.gmail.com>
2012-07-05 17:22 ` Ezequiel Garcia
2012-07-06 14:33 ` Ezequiel Garcia
2012-07-06 15:12 ` Mauro Carvalho Chehab
2012-07-06 15:16 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF5C77C.7030500@redhat.com \
--to=mchehab@redhat.com \
--cc=elezegarcia@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).