linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "Du, Changbin" <changbin.du@gmail.com>
Cc: mchehab@infradead.org, anssi.hannula@iki.fi, gregkh@suse.de,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] media: gpio-ir-recv: add allowed_protos for platform data
Date: Fri, 06 Jul 2012 18:28:11 -0300	[thread overview]
Message-ID: <4FF7586B.9080902@redhat.com> (raw)
In-Reply-To: <4ff3b46c.06da440a.6345.ffff8730@mx.google.com>

Em 04-07-2012 00:11, Du, Changbin escreveu:
> Make it possible to specify allowed RC protocols through the device's
> platform data.
> 
> Signed-off-by: Du, Changbin <changbin.du@gmail.com>

Gah, you trapped me: you've resent it, without using the original message ID.

Too late. I'll keep the version where I've fixed the merge
conflict, as it does the same thing.

Regards,
Mauro.

> ---
> For v2:
> 	Keymap has already done by another patch.
> ---
>   drivers/media/rc/gpio-ir-recv.c |    2 +-
>   include/media/gpio-ir-recv.h    |    7 ++++---
>   2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/rc/gpio-ir-recv.c
> b/drivers/media/rc/gpio-ir-recv.c
> index 59fe60c..38da91e 100644
> --- a/drivers/media/rc/gpio-ir-recv.c
> +++ b/drivers/media/rc/gpio-ir-recv.c
> @@ -84,7 +84,7 @@ static int __devinit gpio_ir_recv_probe(struct
> platform_device *pdev)
>   
>   	rcdev->priv = gpio_dev;
>   	rcdev->driver_type = RC_DRIVER_IR_RAW;
> -	rcdev->allowed_protos = RC_TYPE_ALL;
> +	rcdev->allowed_protos = pdata->allowed_protos ?: RC_TYPE_ALL;
>   	rcdev->input_name = GPIO_IR_DEVICE_NAME;
>   	rcdev->input_phys = GPIO_IR_DEVICE_NAME "/input0";
>   	rcdev->input_id.bustype = BUS_HOST;
> diff --git a/include/media/gpio-ir-recv.h b/include/media/gpio-ir-recv.h
> index 91546f3..0142736 100644
> --- a/include/media/gpio-ir-recv.h
> +++ b/include/media/gpio-ir-recv.h
> @@ -14,9 +14,10 @@
>   #define __GPIO_IR_RECV_H__
>   
>   struct gpio_ir_recv_platform_data {
> -	int gpio_nr;
> -	bool active_low;
> -	const char *map_name;
> +	int		gpio_nr;
> +	bool		active_low;
> +	u64		allowed_protos;
> +	const char	*map_name;
>   };
>   
>   #endif /* __GPIO_IR_RECV_H__ */
> 



      reply	other threads:[~2012-07-06 21:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-04  3:11 [PATCH v2 1/1] media: gpio-ir-recv: add allowed_protos for platform data Du, Changbin
2012-07-06 21:28 ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF7586B.9080902@redhat.com \
    --to=mchehab@redhat.com \
    --cc=anssi.hannula@iki.fi \
    --cc=changbin.du@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).