From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Du Changbin <changbin.du@gmail.com>
Cc: mchehab@infradead.org, anssi.hannula@iki.fi,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Resend PATCH] media: rc: ati_remote.c: code style and compile warning fixing
Date: Sat, 07 Jul 2012 00:09:01 -0300 [thread overview]
Message-ID: <4FF7A84D.5040006@redhat.com> (raw)
In-Reply-To: <031601cd5be2$b8831fb0$29895f10$@gmail.com>
Em 06-07-2012 22:49, Du Changbin escreveu:
>>> diff --git a/drivers/media/rc/ati_remote.c
> b/drivers/media/rc/ati_remote.c
>>> index 7be377f..0df66ac 100644
>>> --- a/drivers/media/rc/ati_remote.c
>>> +++ b/drivers/media/rc/ati_remote.c
>>> @@ -23,6 +23,8 @@
>>> * Vincent Vanackere <vanackere@lif.univ-mrs.fr>
>>> * Added support for the "Lola" remote contributed by:
>>> * Seth Cohn <sethcohn@yahoo.com>
>>> + * Jul 2012: Du, Changbin <changbin.du@gmail.com>
>>> + * Code style and compile warning fixing
>>
>> You shouldn't be changing the driver's authorship just due to codingstyle
>> and warning fixes. Btw, Please split Coding Style form Compilation
> warnings,
>> as they're two different matters.
>
> Sorry, I didn't know this rule. I just want to make a track for me. OK, I
> will resend this patch and remove me from it.
> BTW, I am looking for something to learn these basic rules when sending
> patches. Could you tell me where I can find it?
There are some rules at linuxtv wiki pages, others at the Kernel Documentation
dir and other not so explicit rules like the above that you'll get as you
continue contributing ;)
In opposite to other open source projects, the contribution history is the
git logs, and not inside the comments at the source code.
> Many thanks!
> [Du, Changbin]
Thanks,
Mauro
next prev parent reply other threads:[~2012-07-07 3:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-07 1:49 [Resend PATCH] media: rc: ati_remote.c: code style and compile warning fixing Du Changbin
2012-07-07 3:09 ` Mauro Carvalho Chehab [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-04 8:08 Du, Changbin
2012-07-06 21:32 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF7A84D.5040006@redhat.com \
--to=mchehab@redhat.com \
--cc=anssi.hannula@iki.fi \
--cc=changbin.du@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).