Re: [PATCH 4/4] radio-si470x: Lower firmware version requirements

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 07/07/2012 11:00 AM, Antti Palosaari wrote:
> Hello Hans,
>
> On 07/07/2012 10:58 AM, Hans de Goede wrote:
>> So is your device working properly now? The reason I'm asking it
>> because it is still causing a firmware version warning, and if
>> it works fine I would like to lower the firmware version warning
>> point, so that the warning goes away.
>
> I don't know what is definition of properly in that case.
>
> Problem is that when I use radio application from xawtv3 with that new loopback I hear very often cracks and following errors are printed to the radio screen:
> ALSA lib pcm.c:7339:(snd_pcm_recover) underrun occurred
> or
> ALSA lib pcm.c:7339:(snd_pcm_recover) overrun occurred
>
> Looks like those does not appear, at least it does not crack so often nor errors seen, when I use Rhythmbox to tune and "arecord -D hw:2,0 -r96000 -c2 -f S16_LE | aplay -" to listen.
 >
> I can guess those are not firmware related so warning texts could be removed.

Actually they may very well be firmware related. At least with my firmware there
is a bug where actively asking the device for its register contents, it lets
its audio stream drop.

My patches fix this by waiting for the device to volunteer it register contents
through its usb interrupt in endpoint, which it does at xx times / sec.

So the first question would be, does this dropping of sound happen approx 1 / sec
when using radio?

If so this is caused by radio upating the signal strength it displays 1 / sec. If
you look at radio.c line 981 you will see a radio_getsignal_n_stereo(fd); call
there in the main loop which gets called 1/sec. Try commenting this out.

If commenting this out fixes your sound issues with radio, then the next
question is are you using my 4 recent si470x patches, if not please
give them a try. If you are already using them then I'm afraid that your older
firmware may be broken even more then my also not so new firmware.

Regards,

Hans