Device-tree cross-subsystem binding workshop [was Media system Summit]

Device-tree cross-subsystem binding workshop [was Media system Summit]

[Olof Johansson]

On Thu, Jul 12, 2012 at 12:03 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On Thu July 12 2012 18:48:23 Olof Johansson wrote:
>> On Thu, Jul 12, 2012 at 9:18 AM, Mark Brown
>> <broonie@opensource.wolfsonmicro.com> wrote:
>> > On Thu, Jul 12, 2012 at 10:08:04AM +0200, Sylwester Nawrocki wrote:
>> >
>> >> I'd like to add a "Common device tree bindings for media devices" topic to
>> >> the agenda for consideration.
>> >
>> > It'd be nice to get this to join up with ASoC...
>>
>>
>> There's a handful of various subsystems that have similar topics,
>> maybe slice it the other way and do a device-tree/ACPI breakout that
>> cuts across the various areas instead?
>>
>> Communication really needs to be two-way: Crafting good bindings for a
>> complex piece of hardware isn't trivial and having someone know both
>> the subsystem and device tree principles is rare. At least getting all
>> those people into the same room would be good.
>
> I'm not so sure: I think that most decisions that need to be made are
> quite subsystem specific. Trying to figure out how to implement DT for
> multiple subsystems in one workshop seems unlikely to succeed, simply
> because of lack of time. I also don't think there is much overlap between
> subsystems in this respect, so while the DT implementation for one subsystem
> is discussed, the representatives of other subsystems are twiddling their
> thumbs.
>
> It might be more productive to have one or two DT experts around who
> rotate over the various workshops that have to deal with the DT and can
> offer advice.

One of the real problems right now is the lack of DT reviewers and
general reviewer fatigue. In particular, many of the proposed bindings
tend to have the same issues (focusing too much on how the
platform_data is structured today and not on what the hardware
actually is), and a few other similar things.

Based on that I don't think it's a better solution to have the same
few people walk from room to room to cover the same thing multiple
times. No one has to sit there the whole day and listen on it all, but
for those who are genuinely interested in how other subsystems will
handle these bindings, I think it would be very useful to learn from
how they made their decisions. Don't work in a vacuum, etc.

So, I'd like to formally propose this as a mini-summit or workshop or
whatever you might want to call it. I can help organize it together
with Rob and Grant if needed (especially since Grant has a lot of
other things going on at the moment).

If there's insufficent interest to do this as a separate event we can
try to accomodate for it as part of the ARM mini-summit, but squeezing
all of that in with the rest of the ARM activities in one day will be
hard.


-Olof

Re: Device-tree cross-subsystem binding workshop [was Media system Summit]

[Rob Herring]

On 07/12/2012 08:20 PM, Olof Johansson wrote:
> On Thu, Jul 12, 2012 at 12:03 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> On Thu July 12 2012 18:48:23 Olof Johansson wrote:
>>> On Thu, Jul 12, 2012 at 9:18 AM, Mark Brown
>>> <broonie@opensource.wolfsonmicro.com> wrote:
>>>> On Thu, Jul 12, 2012 at 10:08:04AM +0200, Sylwester Nawrocki wrote:
>>>>
>>>>> I'd like to add a "Common device tree bindings for media devices" topic to
>>>>> the agenda for consideration.
>>>>
>>>> It'd be nice to get this to join up with ASoC...
>>>
>>>
>>> There's a handful of various subsystems that have similar topics,
>>> maybe slice it the other way and do a device-tree/ACPI breakout that
>>> cuts across the various areas instead?
>>>
>>> Communication really needs to be two-way: Crafting good bindings for a
>>> complex piece of hardware isn't trivial and having someone know both
>>> the subsystem and device tree principles is rare. At least getting all
>>> those people into the same room would be good.
>>
>> I'm not so sure: I think that most decisions that need to be made are
>> quite subsystem specific. Trying to figure out how to implement DT for
>> multiple subsystems in one workshop seems unlikely to succeed, simply
>> because of lack of time. I also don't think there is much overlap between
>> subsystems in this respect, so while the DT implementation for one subsystem
>> is discussed, the representatives of other subsystems are twiddling their
>> thumbs.
>>
>> It might be more productive to have one or two DT experts around who
>> rotate over the various workshops that have to deal with the DT and can
>> offer advice.
> 
> One of the real problems right now is the lack of DT reviewers and
> general reviewer fatigue. In particular, many of the proposed bindings
> tend to have the same issues (focusing too much on how the
> platform_data is structured today and not on what the hardware
> actually is), and a few other similar things.

Agreed. It's hard to review things spanning across all subsystems and
define something which works well across platforms. Often within a
single subsystem we repeat things as platforms one by one convert to DT.
On the other hand, I guess re-occurring review issues is a common
problem across the kernel.

Perhaps part of the issue is we're trying to put too much into DT?

It's unfortunate that other than the recovering PPC developers now
working on ARM, there has not been a lot of review from folks that have
worked with DT for a bit longer.

> Based on that I don't think it's a better solution to have the same
> few people walk from room to room to cover the same thing multiple
> times. No one has to sit there the whole day and listen on it all, but
> for those who are genuinely interested in how other subsystems will
> handle these bindings, I think it would be very useful to learn from
> how they made their decisions. Don't work in a vacuum, etc.
> 
> So, I'd like to formally propose this as a mini-summit or workshop or
> whatever you might want to call it. I can help organize it together
> with Rob and Grant if needed (especially since Grant has a lot of
> other things going on at the moment).
> 
> If there's insufficent interest to do this as a separate event we can
> try to accomodate for it as part of the ARM mini-summit, but squeezing
> all of that in with the rest of the ARM activities in one day will be
> hard.

I happy to help organize it. I think keeping it separate from ARM
mini-summit is better otherwise we may end up with somewhat the same
group of ARM developers as past DT discussions.

Rob

> 
> -Olof
> 

Re: [Ksummit-2012-discuss] Device-tree cross-subsystem binding workshop [was Media system Summit]

[Mark Brown]

On Thu, Jul 12, 2012 at 09:55:07PM -0500, Rob Herring wrote:

> Perhaps part of the issue is we're trying to put too much into DT?

I think this is definitely part of it, at times it feels like people
have a shiny new toy so we're jumping into device tree really quickly
for things that perhaps don't need to be pulled out of the code.

Another part of it (and the big problem with translating platform data
directly) is that platform data is easily fungible whereas device tree
should in theory be an ABI and hence needs much closer scrutiny.

Re: [Ksummit-2012-discuss] Device-tree cross-subsystem binding workshop [was Media system Summit]

[Igor Grinberg]

On 07/13/12 04:20, Olof Johansson wrote:
> On Thu, Jul 12, 2012 at 12:03 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> On Thu July 12 2012 18:48:23 Olof Johansson wrote:
>>> On Thu, Jul 12, 2012 at 9:18 AM, Mark Brown
>>> <broonie@opensource.wolfsonmicro.com> wrote:
>>>> On Thu, Jul 12, 2012 at 10:08:04AM +0200, Sylwester Nawrocki wrote:
>>>>
>>>>> I'd like to add a "Common device tree bindings for media devices" topic to
>>>>> the agenda for consideration.
>>>>
>>>> It'd be nice to get this to join up with ASoC...
>>>
>>>
>>> There's a handful of various subsystems that have similar topics,
>>> maybe slice it the other way and do a device-tree/ACPI breakout that
>>> cuts across the various areas instead?
>>>
>>> Communication really needs to be two-way: Crafting good bindings for a
>>> complex piece of hardware isn't trivial and having someone know both
>>> the subsystem and device tree principles is rare. At least getting all
>>> those people into the same room would be good.
>>
>> I'm not so sure: I think that most decisions that need to be made are
>> quite subsystem specific. Trying to figure out how to implement DT for
>> multiple subsystems in one workshop seems unlikely to succeed, simply
>> because of lack of time. I also don't think there is much overlap between
>> subsystems in this respect, so while the DT implementation for one subsystem
>> is discussed, the representatives of other subsystems are twiddling their
>> thumbs.
>>
>> It might be more productive to have one or two DT experts around who
>> rotate over the various workshops that have to deal with the DT and can
>> offer advice.
> 
> One of the real problems right now is the lack of DT reviewers and
> general reviewer fatigue. In particular, many of the proposed bindings
> tend to have the same issues (focusing too much on how the
> platform_data is structured today and not on what the hardware
> actually is), and a few other similar things.
> 
> Based on that I don't think it's a better solution to have the same
> few people walk from room to room to cover the same thing multiple
> times. No one has to sit there the whole day and listen on it all, but
> for those who are genuinely interested in how other subsystems will
> handle these bindings, I think it would be very useful to learn from
> how they made their decisions. Don't work in a vacuum, etc.
> 
> So, I'd like to formally propose this as a mini-summit or workshop or
> whatever you might want to call it. I can help organize it together
> with Rob and Grant if needed (especially since Grant has a lot of
> other things going on at the moment).
> 
> If there's insufficent interest to do this as a separate event we can
> try to accomodate for it as part of the ARM mini-summit, but squeezing
> all of that in with the rest of the ARM activities in one day will be
> hard.

+1


-- 
Regards,
Igor.

Re: [Ksummit-2012-discuss] Device-tree cross-subsystem binding workshop [was Media system Summit]

[Mark Brown]

On Thu, Jul 12, 2012 at 06:20:27PM -0700, Olof Johansson wrote:
> On Thu, Jul 12, 2012 at 12:03 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote:

> > I'm not so sure: I think that most decisions that need to be made are
> > quite subsystem specific. Trying to figure out how to implement DT for
> > multiple subsystems in one workshop seems unlikely to succeed, simply
> > because of lack of time. I also don't think there is much overlap between
> > subsystems in this respect, so while the DT implementation for one subsystem
> > is discussed, the representatives of other subsystems are twiddling their
> > thumbs.

I'm seeing an awful lot of common patterns in the way the hardware is
structured here, we shouldn't be redoing the handling of all these
patterns.  Obviously there will be subsystem specific stuff too but
there's a lot of repetitive boiler plate in the high level hookup.