From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org,
Jean-Philippe Francois <jp.francois@cynove.com>
Subject: Re: [PATCH v2 5/6] omap3isp: preview: Merge gamma correction and gamma bypass
Date: Fri, 13 Jul 2012 12:51:36 +0300 [thread overview]
Message-ID: <4FFFEFA8.10709@iki.fi> (raw)
In-Reply-To: <1341581569-8292-6-git-send-email-laurent.pinchart@ideasonboard.com>
Hi Laurent,
Thanks for the patches.
Laurent Pinchart wrote:
...
> @@ -817,7 +817,7 @@ static const struct preview_update update_attrs[] = {
> offsetof(struct omap3isp_prev_update_config, dcor),
> }, /* OMAP3ISP_PREV_GAMMABYPASS */ {
> NULL,
> - preview_enable_gammabypass,
> + NULL,
> }, /* OMAP3ISP_PREV_DRK_FRM_CAPTURE */ {
> NULL,
> preview_enable_drkframe_capture,
> @@ -835,7 +835,7 @@ static const struct preview_update update_attrs[] = {
> offsetof(struct omap3isp_prev_update_config, nf),
> }, /* OMAP3ISP_PREV_GAMMA */ {
> preview_config_gammacorrn,
> - NULL,
> + preview_enable_gammacorrn,
> offsetof(struct prev_params, gamma),
> FIELD_SIZEOF(struct prev_params, gamma),
> offsetof(struct omap3isp_prev_update_config, gamma),
Doesn't this change the behaviour of the user space API?
I'm not sure if we _really_ need to worry about that _too_ much, but I
think that if OMAP3ISP_PREV_GAMMABYPASS is no longer used anywhere the
definition should be removed as well to prevent anyone accidentally from
using it.
Cheers,
--
Sakari Ailus
sakari.ailus@iki.fi
next prev parent reply other threads:[~2012-07-13 9:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 13:32 [PATCH v2 0/6] omap3isp: preview: Add support for non-GRBG Bayer patterns Laurent Pinchart
2012-07-06 13:32 ` [PATCH v2 1/6] omap3isp: preview: Fix contrast and brightness handling Laurent Pinchart
2012-07-06 13:32 ` [PATCH v2 2/6] omap3isp: preview: Remove lens shading compensation support Laurent Pinchart
2012-07-06 13:32 ` [PATCH v2 3/6] omap3isp: preview: Pass a prev_params pointer to configuration functions Laurent Pinchart
2012-07-06 13:32 ` [PATCH v2 4/6] omap3isp: preview: Reorder " Laurent Pinchart
2012-07-06 13:32 ` [PATCH v2 5/6] omap3isp: preview: Merge gamma correction and gamma bypass Laurent Pinchart
2012-07-13 9:51 ` Sakari Ailus [this message]
2012-07-13 10:00 ` Laurent Pinchart
2012-07-06 13:32 ` [PATCH v2 6/6] omap3isp: preview: Add support for non-GRBG Bayer patterns Laurent Pinchart
2012-07-13 10:12 ` Sakari Ailus
2012-07-13 11:25 ` Laurent Pinchart
2012-07-14 13:32 ` [PATCH v2 0/6] " jean-philippe francois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFFEFA8.10709@iki.fi \
--to=sakari.ailus@iki.fi \
--cc=jp.francois@cynove.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).