Re: [PATCH v3 1/5] media: dt-bindings: add non-pixel property in iris schema

Vikash Garodia
2025-07-02T11:45:30Z

On 7/2/2025 4:53 PM, Krzysztof Kozlowski wrote:
> On 27/06/2025 17:48, Vikash Garodia wrote:
>> +
>> video-codec@aa00000 {
>> compatible = "qcom,sm8550-iris";
>> reg = <0x0aa00000 0xf0000>;
>> @@ -144,12 +176,16 @@ examples:
>> resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>;
>> reset-names = "bus";
>>
>> - iommus = <&apps_smmu 0x1940 0x0000>,
>> - <&apps_smmu 0x1947 0x0000>;
>> + iommus = <&apps_smmu 0x1947 0x0000>;
>
> I missed, that's technically ABI break and nothing in commit msg
> explains that. You need to clearly explain the reasons and impact.
No, it is not. Interface works well with old or new approach.

>
> Best regards,
> Krzysztof