Re: [PATCH v3 0/5] Introduce "non-pixel" sub node within iris video node

Krzysztof Kozlowski
2025-07-02T11:06:02Z

On 27/06/2025 18:30, Bryan O'Donoghue wrote:
> On 27/06/2025 16:48, Vikash Garodia wrote:
>> Changes in v3:
>> - Add info about change in iommus binding (Thanks Krzysztof)
>> - Link to v2:https://lore.kernel.org/r/20250627-video_cb-v2-0-3931c3f49361@quicinc.com
>
> Hmm.
>
> I would be nice to see what also _wasn't_ done i.e. why you didn't do
> what Dmitry was suggesting, IMO that's as important as stating what you
> did change.
>
> Not a huge deal you explained in a response email your logic already but

It is a deal. Not doing what reviewers are asking is not the standard
practice.

> just as suggestion for future, I think its good practice to go through
> each point and say what you did do, what you didn't do, perhaps what you
> tried and then decided to do in a different way.

Best regards,
Krzysztof