Re: [PATCH v3 0/5] Introduce "non-pixel" sub node within iris video node

Vikash Garodia
2025-06-27T17:01:27Z

On 6/27/2025 10:00 PM, Bryan O'Donoghue wrote:
> On 27/06/2025 16:48, Vikash Garodia wrote:
>> Changes in v3:
>> - Add info about change in iommus binding (Thanks Krzysztof)
>> - Link to
>> v2:https://lore.kernel.org/r/20250627-video_cb-v2-0-3931c3f49361@quicinc.com
>
> Hmm.
>
> I would be nice to see what also _wasn't_ done i.e. why you didn't do what
> Dmitry was suggesting, IMO that's as important as stating what you did change.
>
> Not a huge deal you explained in a response email your logic already but just as
> suggestion for future, I think its good practice to go through each point and
> say what you did do, what you didn't do, perhaps what you tried and then decided
> to do in a different way.
I see your point here, and it would be certainly good to document (as a summary
in cover letter) the design approaches which was not considered stating the
limitations as well to drop them out.

Regards,
Vikash
>
> ---
> bod