Re: [PATCH v5] media: i2c: Add ar0234 camera sensor driver

["Yan, Dongcheng" <dongcheng.yan@intel.com>]

Hi Sakari,

On 4/17/2025 2:53 PM, Sakari Ailus wrote:
> Hi Dongcheng,
> 
> On Fri, Apr 11, 2025 at 12:12:49AM +0800, Dongcheng Yan wrote:
>> The driver is implemented with V4L2 framework,
>> and supports following features:
>>
>>     - manual exposure and analog/digital gain control
>>     - vblank/hblank control
>>     - vflip/hflip control
>>     - runtime PM support
>>     - 1280x960@30fps and 1920x1200@60fps support
>>     - dynamical pll_params set
>>
>> Signed-off-by: Dongcheng Yan <dongcheng.yan@intel.com>
> 
> I reviewed Laurent's ar0144 driver and it turns out that the ar0144 and
> ar0234 sensors are nearly identical in their register interface. Thus they
> could be controlled using the same driver, with relatively small changes.
> Laurent's driver programmatically sets the register values in general and
> does not rely on register lists, which is why I prefer that driver.
> 
> Would you be able to add ar0234 support to the ar0144 driver, please?

Do you mean use the ar0144 driver to support the ar0234? two sensors
share the same driver code? Or do I implement the similar
"programmatically sets the register values" in the ar0234 driver?

Thanks,
Dongcheng

> Sensor configuration independent MSRs are totally fine, I presume there are
> some the ar0234 benefits from.
> 
> My apologies for telling you this now, after 5 versions of this driver, but
> I only learned of this very recently.
> 
> I expect Laurent to send v3 of his driver by early next week.
>