Re: [PATCH v5 1/6] media: v4l2: Add Renesas Camera Receiver Unit pixel formats

[Dan Scally <dan.scally@ideasonboard.com>]

Hi Sakari

On 24/06/2025 11:25, Sakari Ailus wrote:
> Hi Daniel,
>
> Thanks for the set.
>
> On Mon, Jun 23, 2025 at 03:43:18PM +0100, Daniel Scally wrote:
>> From: Daniel Scally <dan.scally+renesas@ideasonboard.com>
>>
>> The Renesas Camera Receiver Unit in the RZ/V2H SoC can output RAW
>> data captured from an image sensor without conversion to an RGB/YUV
>> format. In that case the data are packed into 64-bit blocks, with a
>> variable amount of padding in the most significant bits depending on
>> the bitdepth of the data. Add new V4L2 pixel format codes for the new
>> formats, along with documentation to describe them.
>>
>> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>> Signed-off-by: Daniel Scally <dan.scally+renesas@ideasonboard.com>
>> ---
>> Changes in v5:
>>
>> 	- None
>>
>> Changes in v4:
>>
>> 	- Removed references to "Bayer" or "srgb"
>>
>> Changes in v3:
>>
>> 	- Switched from bayer-order specific formats to generic RAWnn
>>
>> Changes in v2:
>>
>> 	- Added labels to the new formats in the documentation file
>> 	- Added 20-bit formats
>> ---
>>   .../userspace-api/media/v4l/pixfmt-bayer.rst       |   1 +
>>   .../userspace-api/media/v4l/pixfmt-rawnn-cru.rst   | 143 +++++++++++++++++++++
>>   drivers/media/v4l2-core/v4l2-common.c              |   6 +
>>   drivers/media/v4l2-core/v4l2-ioctl.c               |   4 +
>>   include/uapi/linux/videodev2.h                     |   6 +
>>   5 files changed, 160 insertions(+)
>>
>> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-bayer.rst b/Documentation/userspace-api/media/v4l/pixfmt-bayer.rst
>> index ed3eb432967d9845d3d65150831d8a7f62dec994..20a8aa04330479ed4d44c8e4fc3d57db8c2e6933 100644
>> --- a/Documentation/userspace-api/media/v4l/pixfmt-bayer.rst
>> +++ b/Documentation/userspace-api/media/v4l/pixfmt-bayer.rst
>> @@ -31,3 +31,4 @@ orders. See also `the Wikipedia article on Bayer filter
>>       pixfmt-srggb14
>>       pixfmt-srggb14p
>>       pixfmt-srggb16
>> +    pixfmt-rawnn-cru
>> diff --git a/Documentation/userspace-api/media/v4l/pixfmt-rawnn-cru.rst b/Documentation/userspace-api/media/v4l/pixfmt-rawnn-cru.rst
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..d786833d0cf355b3955fe63d85c8a211a7a4fb23
>> --- /dev/null
>> +++ b/Documentation/userspace-api/media/v4l/pixfmt-rawnn-cru.rst
>> @@ -0,0 +1,143 @@
>> +.. SPDX-License-Identifier: GFDL-1.1-no-invariants-or-later
>> +
>> +.. _v4l2-pix-fmt-cru-raw10:
>> +.. _v4l2-pix-fmt-cru-raw12:
>> +.. _v4l2-pix-fmt-cru-raw14:
>> +.. _v4l2-pix-fmt-cru-raw20:
>> +
>> +**********************************************************************************************************************************
>> +V4L2_PIX_FMT_CRU_RAW10 ('CR10'), V4L2_PIX_FMT_CRU_RAW12 ('CR12'), V4L2_PIX_FMT_CRU_RAW14 ('CR14'), V4L2_PIX_FMT_CRU_RAW20 ('CR20')
>> +**********************************************************************************************************************************
> Regarding naming, could these be called V4L2_PIX_FMT_RAW_CRUxx, to align
> the naming with the new raw formats?
> <URL:https://www.retiisi.eu/~sailus/v4l2/tmp/common-raw/userspace-api/media/v4l/pixfmt-raw-generic.html>
>
> If you rebase on the metadata series, I can pick this patch in the set. My
> objective is to get this merged in this cycle, which of course also depends
> on review feedback.


Sounds good - I'm happy to rename them sure.


Thanks

Dan

>