From: <Eugen.Hristev@microchip.com>
To: <sakari.ailus@linux.intel.com>
Cc: <leonl@leopardimaging.com>, <linux-media@vger.kernel.org>,
<skomatineni@nvidia.com>, <luca@lucaceresoli.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] media: i2c: imx274: simplify probe function by adding local variable dev
Date: Tue, 23 Nov 2021 11:35:33 +0000 [thread overview]
Message-ID: <4ca5590d-b872-3720-d8f8-ec95a090c689@microchip.com> (raw)
In-Reply-To: <YZzPj4ILWyp4Ouz9@paasikivi.fi.intel.com>
On 11/23/21 1:25 PM, Sakari Ailus wrote:
> Hi Eugen,
>
> On Tue, Nov 23, 2021 at 01:15:20PM +0200, Eugen Hristev wrote:
>> Simplify probe function by adding a local variable dev instead of using
>> &client->dev all the time.
>>
>> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
>
> It's not really wrong to do this, but is it useful?
>
> You can't even unwrap a single line, the lines are just made a little bit
> shorter.
Hi,
I think there are a few (18 +, 21 -) ... but the idea was to make the
probe function a little bit more easy to read.
Up to you if you want to take this patch.
>
> --
> Kind regards,
>
> Sakari Ailus
>
next prev parent reply other threads:[~2021-11-23 11:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 11:15 [PATCH 1/2] media: i2c: imx274: simplify probe function by adding local variable dev Eugen Hristev
2021-11-23 11:15 ` [PATCH 2/2] media: i2c: imx274: implement fwnode parsing Eugen Hristev
2021-11-23 11:23 ` Sakari Ailus
2021-11-23 11:37 ` Eugen.Hristev
2021-11-23 11:25 ` [PATCH 1/2] media: i2c: imx274: simplify probe function by adding local variable dev Sakari Ailus
2021-11-23 11:35 ` Eugen.Hristev [this message]
2021-11-23 11:51 ` Sakari Ailus
2021-11-23 11:35 ` Luca Ceresoli
2021-11-23 11:50 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca5590d-b872-3720-d8f8-ec95a090c689@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=leonl@leopardimaging.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=sakari.ailus@linux.intel.com \
--cc=skomatineni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox