From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:46860 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbbFYVgG (ORCPT ); Thu, 25 Jun 2015 17:36:06 -0400 From: Laurent Pinchart To: Dan Carpenter Cc: Hyun Kwon , Mauro Carvalho Chehab , Michal Simek , =?ISO-8859-1?Q?S=F6ren?= Brinkmann , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] [media] v4l: xilinx: missing error code Date: Fri, 26 Jun 2015 00:36 +0300 Message-ID: <5003072.FJ6mfoskHd@avalon> In-Reply-To: <20150624142831.GB1702@mwanda> References: <20150624142831.GB1702@mwanda> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Dan, Thank you for the patch. On Wednesday 24 June 2015 17:28:31 Dan Carpenter wrote: > We should set "ret" on this error path instead of returning success. > > Fixes: df3305156f98 ('[media] v4l: xilinx: Add Xilinx Video IP core') > Signed-off-by: Dan Carpenter Acked-by: Laurent Pinchart and applied to my tree. > diff --git a/drivers/media/platform/xilinx/xilinx-dma.c > b/drivers/media/platform/xilinx/xilinx-dma.c index 98e50e4..e779c93 100644 > --- a/drivers/media/platform/xilinx/xilinx-dma.c > +++ b/drivers/media/platform/xilinx/xilinx-dma.c > @@ -699,8 +699,10 @@ int xvip_dma_init(struct xvip_composite_device *xdev, > struct xvip_dma *dma, > > /* ... and the buffers queue... */ > dma->alloc_ctx = vb2_dma_contig_init_ctx(dma->xdev->dev); > - if (IS_ERR(dma->alloc_ctx)) > + if (IS_ERR(dma->alloc_ctx)) { > + ret = PTR_ERR(dma->alloc_ctx); > goto error; > + } > > /* Don't enable VB2_READ and VB2_WRITE, as using the read() and write() > * V4L2 APIs would be inefficient. Testing on the command line with a -- Regards, Laurent Pinchart