From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:41258 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753089Ab3JBX3a (ORCPT ); Wed, 2 Oct 2013 19:29:30 -0400 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, sylwester.nawrocki@gmail.com, a.hajda@samsung.com Subject: Re: [PATCH v2 1/4] media: Add pad flag MEDIA_PAD_FL_MUST_CONNECT Date: Thu, 03 Oct 2013 01:29:34 +0200 Message-ID: <5005169.gE657Xh6K1@avalon> In-Reply-To: <1380755873-25835-2-git-send-email-sakari.ailus@iki.fi> References: <1380755873-25835-1-git-send-email-sakari.ailus@iki.fi> <1380755873-25835-2-git-send-email-sakari.ailus@iki.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sakari, Thank you for the patch. On Thursday 03 October 2013 02:17:50 Sakari Ailus wrote: > Pads that set this flag must be connected by an active link for the entity > to stream. > > Signed-off-by: Sakari Ailus > Acked-by: Sylwester Nawrocki Acked-by: Laurent Pinchart > --- > Documentation/DocBook/media/v4l/media-ioc-enum-links.xml | 10 ++++++++++ > include/uapi/linux/media.h | 1 + > 2 files changed, 11 insertions(+) > > diff --git a/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml > b/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml index > 355df43..e357dc9 100644 > --- a/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml > +++ b/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml > @@ -134,6 +134,16 @@ > Output pad, relative to the entity. Output pads source data > and are origins of links. > > + > + MEDIA_PAD_FL_MUST_CONNECT > + If this flag is set and the pad is linked to any other > + pad, then at least one of those links must be enabled for the > + entity to be able to stream. There could be temporary reasons > + (e.g. device configuration dependent) for the pad to need > + enabled links even when this flag isn't set; the absence of the > + flag doesn't imply there is none. The flag has no effect on pads > + without connected links. > + > > > > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index ed49574..d847c76 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -98,6 +98,7 @@ struct media_entity_desc { > > #define MEDIA_PAD_FL_SINK (1 << 0) > #define MEDIA_PAD_FL_SOURCE (1 << 1) > +#define MEDIA_PAD_FL_MUST_CONNECT (1 << 2) > > struct media_pad_desc { > __u32 entity; /* entity ID */ -- Regards, Laurent Pinchart