patches to media_build, and a few other things

patches to media_build, and a few other things

[Hin-Tak Leung]

I have a couple of patches to my local media_build repo, which do these:

- a new option "--as-is" to the build script. It basically suppresses any git pull/rebase to both media_build and the ./media subdirectory (if used in combination with --main-git). In combination to --main-git, you are left on your own and be wholy responsible about what is inside ./media - I use that to check Antti's work (which is on a branch), and also since I have some interrim patches to media_build itself, I would prefer I can tell it not to  pull/merge .

- a small change to v4l/Makefile , to install under /lib/modules/$(KERNELRELEASE)/updates/... - recent fedora seems to have a modprobe preference to load from "../updates/..." (or at least, that's the case of having installed compat-wireless at some stage - one might want to steal some code from that?), when more than one kernel module of the same name exists. This is so as not to trash distro-shipped modules (and also if one cleans out ".../updates/..." and runs "depmod -a", one is back to distro as shipped behavior). Also trashing distro-shipped modules have the side-effect of making drpm not to work and whole kernel packages are downloaded in the next "yum upgrade".

I also have a suggestion to make:

- How http://linux/linuxtv.org/downloads/drivers/linux-media-LATEST.tar.bz2
is generated, probably should be documented. Over the weekend I was playing with one with timestamp Jul 7, and it is quite broken with firstly header files not in the right place (linux/v4l2-common.h instead of media/v4l2-common.h), and also the following:

media_build/v4l/../linux/include/media/v4l2-dev.h:127:2: error: unknown type name 'v4l2_std_id'
media_build/v4l/../linux/include/media/v4l2-dev.h:128:2: error: unknown type name 'v4l2_std_id'
media_build/v4l/../linux/include/media/v4l2-dev.h:135:32: error: 'BASE_VIDIOC_PRIVATE' undeclared here (not in a function)

I see that the Jul 16 version has both of these issues fixed... but I am not against having a look myself if it is urgent enough for me (considered that it was broken for 9 days).

- a few of the firmware files are newer/different than distro-shipped... I am less bothered by it trashing distro-shipped packaged files as the linux-firmware package is rarely upgraded. But maybe one can try pushing some of that upstream?

The last one, something for Antti to figure out:

- I found that that part of backports/api_version.patch, which changes LINUX_VERSION_CODE to V4L2_VERSION in drivers/media/video/v4l2-ioctl.c, is relocated from line 930-ish in http://linux/linuxtv.org/downloads/drivers/linux-media-LATEST.tar.bz2 to 
line 590-ish in Antti's dvb_core branch. So there are commits which are in 
linux-media-LATEST.tar.bz2 and not in Antti's branch or vice versa. (so that's any reason who one wants to know how linux-media-LATEST.tar.bz2 is made).

Re: patches to media_build, and a few other things

[Antti Palosaari]

On 07/17/2012 01:21 AM, Hin-Tak Leung wrote:
> I have a couple of patches to my local media_build repo, which do these:
>
> - a new option "--as-is" to the build script. It basically suppresses any git pull/rebase to both media_build and the ./media subdirectory (if used in combination with --main-git). In combination to --main-git, you are left on your own and be wholy responsible about what is inside ./media - I use that to check Antti's work (which is on a branch), and also since I have some interrim patches to media_build itself, I would prefer I can tell it not to  pull/merge .
>
> - a small change to v4l/Makefile , to install under /lib/modules/$(KERNELRELEASE)/updates/... - recent fedora seems to have a modprobe preference to load from "../updates/..." (or at least, that's the case of having installed compat-wireless at some stage - one might want to steal some code from that?), when more than one kernel module of the same name exists. This is so as not to trash distro-shipped modules (and also if one cleans out ".../updates/..." and runs "depmod -a", one is back to distro as shipped behavior). Also trashing distro-shipped modules have the side-effect of making drpm not to work and whole kernel packages are downloaded in the next "yum upgrade".
>
> I also have a suggestion to make:
>
> - How http://linux/linuxtv.org/downloads/drivers/linux-media-LATEST.tar.bz2
> is generated, probably should be documented. Over the weekend I was playing with one with timestamp Jul 7, and it is quite broken with firstly header files not in the right place (linux/v4l2-common.h instead of media/v4l2-common.h), and also the following:
>
> media_build/v4l/../linux/include/media/v4l2-dev.h:127:2: error: unknown type name 'v4l2_std_id'
> media_build/v4l/../linux/include/media/v4l2-dev.h:128:2: error: unknown type name 'v4l2_std_id'
> media_build/v4l/../linux/include/media/v4l2-dev.h:135:32: error: 'BASE_VIDIOC_PRIVATE' undeclared here (not in a function)
>
> I see that the Jul 16 version has both of these issues fixed... but I am not against having a look myself if it is urgent enough for me (considered that it was broken for 9 days).
>
> - a few of the firmware files are newer/different than distro-shipped... I am less bothered by it trashing distro-shipped packaged files as the linux-firmware package is rarely upgraded. But maybe one can try pushing some of that upstream?
>
> The last one, something for Antti to figure out:
>
> - I found that that part of backports/api_version.patch, which changes LINUX_VERSION_CODE to V4L2_VERSION in drivers/media/video/v4l2-ioctl.c, is relocated from line 930-ish in http://linux/linuxtv.org/downloads/drivers/linux-media-LATEST.tar.bz2 to
> line 590-ish in Antti's dvb_core branch. So there are commits which are in
> linux-media-LATEST.tar.bz2 and not in Antti's branch or vice versa. (so that's any reason who one wants to know how linux-media-LATEST.tar.bz2 is made).

I used Linus 3.5 development tree as a base and rebased it continuously 
to latest rc. Current media_build.git seems to download some older 
files. I could guess it is tar'ed from Kernel 3.4 /drivers/media/

Patch which likely breaks backports/api_version.patch is that:
http://www.mail-archive.com/linuxtv-commits@linuxtv.org/msg13388.html

regards
Antti

-- 
http://palosaari.fi/

Re: patches to media_build, and a few other things

[Hin-Tak Leung]

--- On Tue, 17/7/12, Antti Palosaari <crope@iki.fi> wrote:

<snipped>
> > The last one, something for Antti to figure out:
> >
> > - I found that that part of
> backports/api_version.patch, which changes
> LINUX_VERSION_CODE to V4L2_VERSION in
> drivers/media/video/v4l2-ioctl.c, is relocated from line
> 930-ish in http://linux/linuxtv.org/downloads/drivers/linux-media-LATEST.tar.bz2
> to
> > line 590-ish in Antti's dvb_core branch. So there are
> commits which are in
> > linux-media-LATEST.tar.bz2 and not in Antti's branch or
> vice versa. (so that's any reason who one wants to know how
> linux-media-LATEST.tar.bz2 is made).
> 
> I used Linus 3.5 development tree as a base and rebased it
> continuously 
> to latest rc. Current media_build.git seems to download some
> older 
> files. I could guess it is tar'ed from Kernel 3.4
> /drivers/media/
> 
> Patch which likely breaks backports/api_version.patch is
> that:
> http://www.mail-archive.com/linuxtv-commits@linuxtv.org/msg13388.html

No, it is not that. the diff should look like it deletes a chunk of lines around 930 and adds a similar chunk around line 590, spanning a few lines which includes LINUX_VERSION_CODE/V4L2_VERSION .

There shouldn't be any need for guess work - the regular tar ball snapshot is set up by some person, so there should be an authoritative answer...

By the way, I was doing a bit of travelling in the last few days - and got fairly good reception with just the small 5-in aerial in two places; on the 5th floor of a hotel in Brighton (a coastal city in south UK) and the 4th floor by a correct-facing window (same building one floor below interior was crap) local. So it seems that the high you go in UK (or in SE UK), the better. That probably explains why it is so bad in my place - mid-way between two transmitters, and also on the ground floor just outside floodable distance from the local river (i.e. as low in altitude as one can get...).

Re: patches to media_build, and a few other things

[Mauro Carvalho Chehab]

Hi Hin-Tak,

Em 17-07-2012 11:35, Antti Palosaari escreveu:
> On 07/17/2012 01:21 AM, Hin-Tak Leung wrote:

It seems I lost your original email. Anyway:

>> I have a couple of patches to my local media_build repo, which do these:
>>
>> - a new option "--as-is" to the build script. It basically suppresses any git pull/rebase to both media_build and the ./media subdirectory (if used in combination with --main-git). In combination to --main-git, you are left on your own and be wholy responsible about what is inside ./media - I use that to check Antti's work (which is on a branch), and also since I have some interrim patches to media_build itself, I would prefer I can tell it not to  pull/merge .

Seems fine for me.
>>
>> - a small change to v4l/Makefile , to install under /lib/modules/$(KERNELRELEASE)/updates/... - recent fedora seems to have a modprobe preference to load from "../updates/..." (or at least, that's the case of having installed compat-wireless at some stage - one might want to steal some code from that?), when more than one kernel module of the same name exists. This is so as not to trash distro-shipped modules (and also if one cleans out ".../updates/..." and runs "depmod -a", one is back to distro as shipped behavior). Also trashing distro-shipped modules have the side-effect of making drpm not to work and whole kernel packages are downloaded in the next "yum upgrade".

This needs to be smart enough to detect if the system is Fedora and if it is a version compatible with "updates" (17 or upper ?).

It should be noticed that Ubuntu has a similar kind of preference, but it uses the modules on a separate place.


>>
>> I also have a suggestion to make:
>>
>> - How http://linux/linuxtv.org/downloads/drivers/linux-media-LATEST.tar.bz2
>> is generated, probably should be documented. Over the weekend I was playing with one with timestamp Jul 7, and it is quite broken with firstly header files not in the right place (linux/v4l2-common.h instead of media/v4l2-common.h), and also the following:

It does:
	$ run make -C linux todaytar DIR=~/tmp/media_build

The script should be updating the media_build to the very latest version.

I'll double check if this is happening fine.

Regards,
Mauro