Re: [PATCH v2 1/2] v4l: Add factory register values form S5K4ECGX sensor

[Sylwester Nawrocki <sylvester.nawrocki@gmail.com>]

Hi Sangwook,

On 07/19/2012 02:14 PM, Sangwook Lee wrote:
> Add factory default settings for S5K4ECGX sensor registers.
> I copied them from the reference code of Samsung S.LSI.

I'm pretty sure we can do better than that. I've started S5K6AAFX sensor 
driver development with similar set of write-only register address/value
arrays, that stored mainly register default values after the device reset,
or were configuring presets that were never used.

If you lok at the s5k6aa driver, you'll find only one relatively small
array of register values for the analog processing block settings.
It's true that I had to reverse engineer a couple of things, but I also
had a relatively good datasheet for the sensor.
 
> According to comments from the reference code, they do not
> recommend any changes of these settings.

Yes, but it doesn't mean cannot convert, at least part of, those ugly
tables into function calls.

Have you tried to contact Samsung S.LSI for a datasheet that would 
contain better registers' description ?

--

Thanks,
Sylwester