From: Tim Gardner <tim.gardner@canonical.com>
To: Andy Walls <awalls@md.metrocast.net>
Cc: linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>,
ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage
Date: Fri, 27 Jul 2012 09:45:22 -0600 [thread overview]
Message-ID: <5012B792.20400@canonical.com> (raw)
In-Reply-To: <1343341295.2575.18.camel@palomino.walls.org>
On 07/26/2012 04:21 PM, Andy Walls wrote:
> On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote:
>> Cc: Andy Walls <awalls@md.metrocast.net>
>> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
>> Cc: ivtv-devel@ivtvdriver.org
>> Cc: linux-media@vger.kernel.org
>> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
>> ---
>> drivers/media/video/ivtv/ivtv-firmware.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c
>> index 02c5ade..6ec7705 100644
>> --- a/drivers/media/video/ivtv/ivtv-firmware.c
>> +++ b/drivers/media/video/ivtv/ivtv-firmware.c
>> @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where)
>>
>> return res;
>> }
>> +
>> +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME);
>> +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME);
>> +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME);
>
> Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the
> CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even
> in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME
> file is non-fatal.)
>
> I would not want anything in user-space or kernel space preventing the
> ivtv module from loading, if some of those files don't exist.
>
> Regards,
> Andy
>
MODULE_FIRMWARE is informational only and has no runtime impact.
rtg
--
Tim Gardner tim.gardner@canonical.com
next prev parent reply other threads:[~2012-07-27 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 18:26 [PATCH] ivtv: Declare MODULE_FIRMWARE usage Tim Gardner
2012-07-26 22:21 ` Andy Walls
2012-07-27 15:45 ` Tim Gardner [this message]
2012-07-28 16:52 ` Andy Walls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5012B792.20400@canonical.com \
--to=tim.gardner@canonical.com \
--cc=awalls@md.metrocast.net \
--cc=ivtv-devel@ivtvdriver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).