From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.tpi.com ([70.99.223.143]:3136 "EHLO mail.tpi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365Ab2G0Prz (ORCPT ); Fri, 27 Jul 2012 11:47:55 -0400 Message-ID: <5012B792.20400@canonical.com> Date: Fri, 27 Jul 2012 09:45:22 -0600 From: Tim Gardner MIME-Version: 1.0 To: Andy Walls CC: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org Subject: Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage References: <1343327180-94759-1-git-send-email-tim.gardner@canonical.com> <1343341295.2575.18.camel@palomino.walls.org> In-Reply-To: <1343341295.2575.18.camel@palomino.walls.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 07/26/2012 04:21 PM, Andy Walls wrote: > On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote: >> Cc: Andy Walls >> Cc: Mauro Carvalho Chehab >> Cc: ivtv-devel@ivtvdriver.org >> Cc: linux-media@vger.kernel.org >> Signed-off-by: Tim Gardner >> --- >> drivers/media/video/ivtv/ivtv-firmware.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c >> index 02c5ade..6ec7705 100644 >> --- a/drivers/media/video/ivtv/ivtv-firmware.c >> +++ b/drivers/media/video/ivtv/ivtv-firmware.c >> @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where) >> >> return res; >> } >> + >> +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME); >> +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME); >> +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME); > > Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the > CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME. (And even > in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME > file is non-fatal.) > > I would not want anything in user-space or kernel space preventing the > ivtv module from loading, if some of those files don't exist. > > Regards, > Andy > MODULE_FIRMWARE is informational only and has no runtime impact. rtg -- Tim Gardner tim.gardner@canonical.com