From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:46425 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237Ab2HBGuW (ORCPT ); Thu, 2 Aug 2012 02:50:22 -0400 Message-ID: <501A2313.3000702@ti.com> Date: Thu, 2 Aug 2012 12:19:55 +0530 From: Prabhakar Lad MIME-Version: 1.0 To: Sakari Ailus CC: LMML , dlos , Manjunath Hadli , Laurent Pinchart , Hans Verkuil , Guennadi Liakhovetski Subject: Re: [PATCH v7 2/2] v4l2: add new pixel formats supported on dm365 References: <1343386505-8695-1-git-send-email-prabhakar.lad@ti.com> <1343386505-8695-3-git-send-email-prabhakar.lad@ti.com> <20120802002938.GN26642@valkosipuli.retiisi.org.uk> In-Reply-To: <20120802002938.GN26642@valkosipuli.retiisi.org.uk> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sakari, Thanks for the review. On Thursday 02 August 2012 05:59 AM, Sakari Ailus wrote: > Hi Prabhakar, > > Thanks for the patch. > > On Fri, Jul 27, 2012 at 04:25:05PM +0530, Prabhakar Lad wrote: >> From: Manjunath Hadli >> >> add new macro V4L2_PIX_FMT_SGRBG10ALAW8 and associated formats >> to represent Bayer format frames compressed by A-LAW algorithm, >> add V4L2_PIX_FMT_UV8 to represent storage of CbCr data (UV interleaved) >> only. >> >> Signed-off-by: Manjunath Hadli >> Signed-off-by: Lad, Prabhakar >> Cc: Laurent Pinchart >> Cc: Sakari Ailus >> Cc: Hans Verkuil >> Cc: Guennadi Liakhovetski >> --- >> .../DocBook/media/v4l/pixfmt-srggb10alaw8.xml | 34 +++++++++++ >> Documentation/DocBook/media/v4l/pixfmt-uv8.xml | 62 ++++++++++++++++++++ >> Documentation/DocBook/media/v4l/pixfmt.xml | 2 + >> include/linux/videodev2.h | 8 +++ >> 4 files changed, 106 insertions(+), 0 deletions(-) >> create mode 100644 Documentation/DocBook/media/v4l/pixfmt-srggb10alaw8.xml >> create mode 100644 Documentation/DocBook/media/v4l/pixfmt-uv8.xml >> >> diff --git a/Documentation/DocBook/media/v4l/pixfmt-srggb10alaw8.xml b/Documentation/DocBook/media/v4l/pixfmt-srggb10alaw8.xml >> new file mode 100644 >> index 0000000..c934192 >> --- /dev/null >> +++ b/Documentation/DocBook/media/v4l/pixfmt-srggb10alaw8.xml >> @@ -0,0 +1,34 @@ >> + >> + >> + >> + V4L2_PIX_FMT_SBGGR10ALAW8 ('aBA8'), >> + V4L2_PIX_FMT_SGBRG10ALAW8 ('aGA8'), >> + V4L2_PIX_FMT_SGRBG10ALAW8 ('agA8'), >> + V4L2_PIX_FMT_SRGGB10ALAW8 ('aRA8'), >> + >> + &manvol; >> + >> + >> + >> + V4L2_PIX_FMT_SBGGR10ALAW8 >> + >> + >> + V4L2_PIX_FMT_SGBRG10ALAW8 >> + >> + >> + V4L2_PIX_FMT_SGRBG10ALAW8 >> + >> + >> + V4L2_PIX_FMT_SRGGB10ALAW8 >> + >> + 10-bit Bayer formats compressed to 8 bits >> + >> + >> + Description >> + The following four pixel formats are raw sRGB / Bayer >> + formats with 10 bits per color compressed to 8 bits each, >> + using the A-LAW algorithm. Each color component consumes 8 >> + bits of memory. In other respects this format is similar to >> + . >> + >> + >> diff --git a/Documentation/DocBook/media/v4l/pixfmt-uv8.xml b/Documentation/DocBook/media/v4l/pixfmt-uv8.xml >> new file mode 100644 >> index 0000000..c507c1f >> --- /dev/null >> +++ b/Documentation/DocBook/media/v4l/pixfmt-uv8.xml >> @@ -0,0 +1,62 @@ >> + >> + >> + V4L2_PIX_FMT_UV8 ('UV8') >> + &manvol; >> + >> + >> + V4L2_PIX_FMT_UV8 >> + UV plane interleaved >> + >> + >> + Description >> + In this format there is no Y plane, Only CbCr plane. ie >> + (UV interleaved) >> + >> + >> + <constant>V4L2_PIX_FMT_UV8</constant> >> + pixel image >> + >> + >> + >> + Byte Order. >> + Each cell is one byte. >> + >> + >> + >> + >> + >> + start + 0: >> + Cb00 >> + Cr00 >> + Cb01 >> + Cr01 >> + >> + >> + start + 4: >> + Cb10 >> + Cr10 >> + Cb11 >> + Cr11 >> + >> + >> + start + 8: >> + Cb20 >> + Cr20 >> + Cb21 >> + Cr21 >> + >> + >> + start + 12: >> + Cb30 >> + Cr30 >> + Cb31 >> + Cr31 >> + >> + >> + >> + >> + >> + >> + >> + >> + >> diff --git a/Documentation/DocBook/media/v4l/pixfmt.xml b/Documentation/DocBook/media/v4l/pixfmt.xml >> index e58934c..930f55d 100644 >> --- a/Documentation/DocBook/media/v4l/pixfmt.xml >> +++ b/Documentation/DocBook/media/v4l/pixfmt.xml >> @@ -673,6 +673,7 @@ access the palette, this must be done with ioctls of the Linux framebuffer API.< >> &sub-srggb8; >> &sub-sbggr16; >> &sub-srggb10; >> + &sub-srggb10alaw8; >> &sub-srggb10dpcm8; >> &sub-srggb12; >> >> @@ -701,6 +702,7 @@ information. >> &sub-y12; >> &sub-y10b; >> &sub-y16; >> + &sub-uv8; >> &sub-yuyv; >> &sub-uyvy; >> &sub-yvyu; >> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h >> index 5d78910..2cdf2c1 100644 >> --- a/include/linux/videodev2.h >> +++ b/include/linux/videodev2.h >> @@ -329,6 +329,9 @@ struct v4l2_pix_format { >> /* Palette formats */ >> #define V4L2_PIX_FMT_PAL8 v4l2_fourcc('P', 'A', 'L', '8') /* 8 8-bit palette */ >> >> +/* Chrominance formats */ >> +#define V4L2_PIX_FMT_UV8 v4l2_fourcc('U', 'V', '8', ' ') /* 8 UV 4:4 */ > > Is that an extra space I see on the line above? :) > Uhh missed it , I'll fix that for v8. With that fix can I add your Ack? > Now that you're defining a new kind of a format, could you add a few lines > about it to Documentation/video4linux/4CCs.txt, please? That may be a > separate patch if you wish. > Yes sure, we will keep it as a separate patch. I need suggestion for this (Hans, Laurent, Guennadi your views please). Thx, --Prabhakar Lad >> /* Luminance+Chrominance formats */ >> #define V4L2_PIX_FMT_YVU410 v4l2_fourcc('Y', 'V', 'U', '9') /* 9 YVU 4:1:0 */ >> #define V4L2_PIX_FMT_YVU420 v4l2_fourcc('Y', 'V', '1', '2') /* 12 YVU 4:2:0 */ >> @@ -378,6 +381,11 @@ struct v4l2_pix_format { >> #define V4L2_PIX_FMT_SGBRG12 v4l2_fourcc('G', 'B', '1', '2') /* 12 GBGB.. RGRG.. */ >> #define V4L2_PIX_FMT_SGRBG12 v4l2_fourcc('B', 'A', '1', '2') /* 12 GRGR.. BGBG.. */ >> #define V4L2_PIX_FMT_SRGGB12 v4l2_fourcc('R', 'G', '1', '2') /* 12 RGRG.. GBGB.. */ >> + /* 10bit raw bayer a-law compressed to 8 bits */ >> +#define V4L2_PIX_FMT_SBGGR10ALAW8 v4l2_fourcc('a', 'B', 'A', '8') >> +#define V4L2_PIX_FMT_SGBRG10ALAW8 v4l2_fourcc('a', 'G', 'A', '8') >> +#define V4L2_PIX_FMT_SGRBG10ALAW8 v4l2_fourcc('a', 'g', 'A', '8') >> +#define V4L2_PIX_FMT_SRGGB10ALAW8 v4l2_fourcc('a', 'R', 'A', '8') >> /* 10bit raw bayer DPCM compressed to 8 bits */ >> #define V4L2_PIX_FMT_SBGGR10DPCM8 v4l2_fourcc('b', 'B', 'A', '8') >> #define V4L2_PIX_FMT_SGBRG10DPCM8 v4l2_fourcc('b', 'G', 'A', '8') > > Kind regards, >