From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Dror Cohen <dror@liveu.tv>
Cc: linux-media@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com,
mchehab@infradead.org
Subject: Re: [PATCH 1/1] media/video: vpif: fixing function name start to vpif_config_params
Date: Thu, 02 Aug 2012 14:49:04 +0400 [thread overview]
Message-ID: <501A5B20.9080903@mvista.com> (raw)
In-Reply-To: <1343893232-19543-2-git-send-email-dror@liveu.tv>
Hello.
On 02-08-2012 11:40, Dror Cohen wrote:
> diff --git a/drivers/media/video/davinci/vpif_capture.h b/drivers/media/video/davinci/vpif_capture.h
> index a693d4e..8863de1 100644
> --- a/drivers/media/video/davinci/vpif_capture.h
> +++ b/drivers/media/video/davinci/vpif_capture.h
> @@ -144,7 +144,7 @@ struct vpif_device {
> struct v4l2_subdev **sd;
> };
>
> -struct vpif_config_params {
> +struct config_vpif_params_t {
IMO, '_t' postfix is used only for *typedef* names.
> diff --git a/drivers/media/video/davinci/vpif_display.h b/drivers/media/video/davinci/vpif_display.h
> index 56879d1..3e14807 100644
> --- a/drivers/media/video/davinci/vpif_display.h
> +++ b/drivers/media/video/davinci/vpif_display.h
> @@ -154,7 +154,7 @@ struct vpif_device {
>
> };
>
> -struct vpif_config_params {
> +struct config_vpif_params_t {
Same comment.
WBR, Sergei
next prev parent reply other threads:[~2012-08-02 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 7:40 [PATCH 0/1] media/video: vpif: fixing function name start to vpif_config_params Dror Cohen
2012-08-02 7:40 ` [PATCH 1/1] " Dror Cohen
2012-08-02 10:49 ` Sergei Shtylyov [this message]
2012-08-02 10:51 ` [PATCH 0/1] " Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501A5B20.9080903@mvista.com \
--to=sshtylyov@mvista.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=dror@liveu.tv \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).