From: poma <pomidorabelisima@gmail.com>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: Antti Palosaari <crope@iki.fi>,
linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH] [BUG] Re: dvb_usb_lmedm04 crash Kernel (rs2000)
Date: Fri, 03 Aug 2012 13:21:33 +0200 [thread overview]
Message-ID: <501BB43D.70907@gmail.com> (raw)
In-Reply-To: <1343950313.11458.10.camel@router7789>
On 08/03/2012 01:31 AM, Malcolm Priestley wrote:
> On Thu, 2012-08-02 at 23:54 +0300, Antti Palosaari wrote:
>> Moi Malcolm,
>> Any idea why this seems to crash Kernel just when device is plugged?
>>
> Hi Antti
>
> Yes, there missing error handling when no firmware file found.
>
> It seems that this is more of a problem with udev-182+.
>
> However, so far udev-182 is only a problem on first ever plug.
>
> Regards
>
>
> Malcolm
>
>
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> ---
> drivers/media/dvb/dvb-usb/lmedm04.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c
> index 25d1031..26ba5bc 100644
> --- a/drivers/media/dvb/dvb-usb/lmedm04.c
> +++ b/drivers/media/dvb/dvb-usb/lmedm04.c
> @@ -878,6 +878,10 @@ static int lme_firmware_switch(struct usb_device *udev, int cold)
> fw_lme = fw_c_rs2000;
> ret = request_firmware(&fw, fw_lme, &udev->dev);
> dvb_usb_lme2510_firmware = TUNER_RS2000;
> + if (ret == 0)
> + break;
> + info("FRM No Firmware Found - please install");
> + cold_fw = 0;
> break;
> default:
> fw_lme = fw_c_s7395;
>
Do we need fw blob anymore!?
http://www.spinics.net/lists/hotplug/msg05257.html
…
"Firmware is loaded natively by udev now, the external 'firmware' binary
is no longer used."
…
Cheers,
poma
next prev parent reply other threads:[~2012-08-03 11:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 20:54 dvb_usb_lmedm04 crash Kernel Antti Palosaari
2012-08-02 23:31 ` [PATCH] [BUG] Re: dvb_usb_lmedm04 crash Kernel (rs2000) Malcolm Priestley
2012-08-03 11:21 ` poma [this message]
2012-08-06 18:46 ` Antti Palosaari
2012-08-06 20:41 ` Malcolm Priestley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501BB43D.70907@gmail.com \
--to=pomidorabelisima@gmail.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).