linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Mike Dyer <mike.dyer@md-soft.co.uk>
Cc: LMML <linux-media@vger.kernel.org>, linux-samsung-soc@vger.kernel.org
Subject: Re: s5p-fimc capturing interlaced BT656
Date: Fri, 03 Aug 2012 22:28:28 +0200	[thread overview]
Message-ID: <501C346C.9000204@gmail.com> (raw)
In-Reply-To: <1344024117.1907.8.camel@edge.config>

On 08/03/2012 10:01 PM, Mike Dyer wrote:
> I have indeed tried setting that, but with no effect.  However, checking
> through the datasheet for the FIMC I discovered a DMA output (CIOCTRL)
> register bit called 'Weave_Out'. The description is:
> 
> "Even and Odd fields can be weaved together and combined to form a
> complete progressive frame by hardware. This field is useful for
> interlace DMA output mode (Interlace_out or CAM_INTERLACE). Even field
> address (1st frame start address) is used weave address. Odd fields
> address (2nd frame start address) is ignored."
> 
> This does produce full sized frames, but I still seem to only be getting
> one field per frame, with a blank line inserted between each real line.
> Setting both interlace and weave doesn't seem to help. So, something
> still missing...
> 
> I wonder if the irq handler is getting called for each field, maybe we
> need to wait for two interrupts before dequeing the frame?

Hmm, might be worth to try. But I'm wondering if the output DMA handling
doesn't need to be reworked for that. According to the datasheet (Figure 
2-20 Frame Buffer Control), even fields are written to DMA buffer with 
even index (e.g. 0) and odd fields are written to DMA buffer with odd 
index (e.g. 1). So possibly, if we set same address at two DMA buffer 
start address registers (e.g. FIMC_REG_CIOYSA(0), FIMC_REG_CIOYSA(1)) 
then even and odd frame will be written to proper memory location ?

This might not be very difficult to implement.

--

Regards,
Sylwester

      reply	other threads:[~2012-08-03 20:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-02 12:48 s5p-fimc capturing interlaced BT656 Mike Dyer
2012-08-03 19:17 ` Sylwester Nawrocki
2012-08-03 20:01   ` Mike Dyer
2012-08-03 20:28     ` Sylwester Nawrocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=501C346C.9000204@gmail.com \
    --to=sylvester.nawrocki@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mike.dyer@md-soft.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).