From: Lars-Peter Clausen <lars@metafoo.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get
Date: Mon, 06 Aug 2012 16:37:17 +0200 [thread overview]
Message-ID: <501FD69D.7070702@metafoo.de> (raw)
In-Reply-To: <20120806142650.GT4403@mwanda>
On 08/06/2012 04:26 PM, Dan Carpenter wrote:
> On Mon, Aug 06, 2012 at 05:23:23PM +0300, Dan Carpenter wrote:
>> On Sat, Aug 04, 2012 at 08:23:27PM +0200, Julia Lawall wrote:
>>> @@ -922,12 +920,7 @@ static int emmaprp_probe(struct platform_device *pdev)
>>>
>>> platform_set_drvdata(pdev, pcdev);
>>>
>>> - if (devm_request_mem_region(&pdev->dev, res_emma->start,
>>> - resource_size(res_emma), MEM2MEM_NAME) == NULL)
>>> - goto rel_vdev;
>>> -
>>> - pcdev->base_emma = devm_ioremap(&pdev->dev, res_emma->start,
>>> - resource_size(res_emma));
>>> + pcdev->base_emma = devm_request_and_ioremap(&pdev->dev, res_emma);
>>> if (!pcdev->base_emma)
>>> goto rel_vdev;
>>
>> This was in the original code, but there is a "ret = -ENOMEM;"
>> missing here, and again a couple lines down in the original code.
>>
>
> Or should that be -EIO instead of -ENOMEM? I'm not sure.
-ENXIO is usually used in such a case.
- Lars
next prev parent reply other threads:[~2012-08-06 14:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 18:23 [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get Julia Lawall
2012-08-06 14:23 ` Dan Carpenter
2012-08-06 14:26 ` Dan Carpenter
2012-08-06 14:37 ` Lars-Peter Clausen [this message]
2012-08-06 19:53 ` Julia.Lawall
2012-08-06 19:53 ` Julia.Lawall
2012-08-10 13:59 ` Julia Lawall
2012-08-13 19:49 ` Mauro Carvalho Chehab
2012-08-13 19:57 ` Julia Lawall
2012-08-13 20:20 ` Julia Lawall
2012-08-14 1:40 ` Mauro Carvalho Chehab
2012-08-14 6:30 ` Julia Lawall
2012-08-14 9:54 ` Mauro Carvalho Chehab
2012-08-14 13:23 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501FD69D.7070702@metafoo.de \
--to=lars@metafoo.de \
--cc=Julia.Lawall@lip6.fr \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).