From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:45417 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317Ab2HJK1I (ORCPT ); Fri, 10 Aug 2012 06:27:08 -0400 Message-ID: <5024E1E9.6090605@iki.fi> Date: Fri, 10 Aug 2012 13:26:49 +0300 From: Antti Palosaari MIME-Version: 1.0 To: Dan Carpenter CC: Mauro Carvalho Chehab , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] [media] qt1010: signedness bug in qt1010_init_meas1() References: <20120810092502.GD26875@elgon.mountain> In-Reply-To: <20120810092502.GD26875@elgon.mountain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 08/10/2012 12:25 PM, Dan Carpenter wrote: > qt1010_init_meas2() returns zero on success and negative error codes on > failure so the return type should be int instead of u8. > > Signed-off-by: Dan Carpenter Acked-by: Antti Palosaari > > diff --git a/drivers/media/common/tuners/qt1010.c b/drivers/media/common/tuners/qt1010.c > index 2d79b1f..bdc39e1 100644 > --- a/drivers/media/common/tuners/qt1010.c > +++ b/drivers/media/common/tuners/qt1010.c > @@ -288,7 +288,7 @@ static int qt1010_init_meas1(struct qt1010_priv *priv, > return qt1010_writereg(priv, 0x1e, 0x00); > } > > -static u8 qt1010_init_meas2(struct qt1010_priv *priv, > +static int qt1010_init_meas2(struct qt1010_priv *priv, > u8 reg_init_val, u8 *retval) > { > u8 i, val; > -- http://palosaari.fi/