* [PATCH] [media] nec-decoder: fix NEC decoding for Pioneer Laserdisc CU-700 remote
@ 2012-07-31 10:37 Sean Young
2012-08-11 20:31 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: Sean Young @ 2012-07-31 10:37 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Jarod Wilson, linux-media; +Cc: lirc-list, Sean Young
This remote sends a header pulse of 8150us followed by a space of 4000us.
Signed-off-by: Sean Young <sean@mess.org>
---
drivers/media/rc/ir-nec-decoder.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/rc/ir-nec-decoder.c b/drivers/media/rc/ir-nec-decoder.c
index 3c9431a..2ca509e 100644
--- a/drivers/media/rc/ir-nec-decoder.c
+++ b/drivers/media/rc/ir-nec-decoder.c
@@ -70,7 +70,7 @@ static int ir_nec_decode(struct rc_dev *dev, struct ir_raw_event ev)
if (!ev.pulse)
break;
- if (eq_margin(ev.duration, NEC_HEADER_PULSE, NEC_UNIT / 2)) {
+ if (eq_margin(ev.duration, NEC_HEADER_PULSE, NEC_UNIT * 2)) {
data->is_nec_x = false;
data->necx_repeat = false;
} else if (eq_margin(ev.duration, NECX_HEADER_PULSE, NEC_UNIT / 2))
@@ -86,7 +86,7 @@ static int ir_nec_decode(struct rc_dev *dev, struct ir_raw_event ev)
if (ev.pulse)
break;
- if (eq_margin(ev.duration, NEC_HEADER_SPACE, NEC_UNIT / 2)) {
+ if (eq_margin(ev.duration, NEC_HEADER_SPACE, NEC_UNIT)) {
data->state = STATE_BIT_PULSE;
return 0;
} else if (eq_margin(ev.duration, NEC_REPEAT_SPACE, NEC_UNIT / 2)) {
--
1.7.11.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] nec-decoder: fix NEC decoding for Pioneer Laserdisc CU-700 remote
2012-07-31 10:37 [PATCH] [media] nec-decoder: fix NEC decoding for Pioneer Laserdisc CU-700 remote Sean Young
@ 2012-08-11 20:31 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2012-08-11 20:31 UTC (permalink / raw)
To: Sean Young; +Cc: Jarod Wilson, linux-media, lirc-list
Em 31-07-2012 07:37, Sean Young escreveu:
> This remote sends a header pulse of 8150us followed by a space of 4000us.
> Signed-off-by: Sean Young <sean@mess.org>
> ---
> drivers/media/rc/ir-nec-decoder.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/rc/ir-nec-decoder.c b/drivers/media/rc/ir-nec-decoder.c
> index 3c9431a..2ca509e 100644
> --- a/drivers/media/rc/ir-nec-decoder.c
> +++ b/drivers/media/rc/ir-nec-decoder.c
> @@ -70,7 +70,7 @@ static int ir_nec_decode(struct rc_dev *dev, struct ir_raw_event ev)
> if (!ev.pulse)
> break;
>
> - if (eq_margin(ev.duration, NEC_HEADER_PULSE, NEC_UNIT / 2)) {
> + if (eq_margin(ev.duration, NEC_HEADER_PULSE, NEC_UNIT * 2)) {
> data->is_nec_x = false;
> data->necx_repeat = false;
> } else if (eq_margin(ev.duration, NECX_HEADER_PULSE, NEC_UNIT / 2))
> @@ -86,7 +86,7 @@ static int ir_nec_decode(struct rc_dev *dev, struct ir_raw_event ev)
> if (ev.pulse)
> break;
>
> - if (eq_margin(ev.duration, NEC_HEADER_SPACE, NEC_UNIT / 2)) {
> + if (eq_margin(ev.duration, NEC_HEADER_SPACE, NEC_UNIT)) {
> data->state = STATE_BIT_PULSE;
> return 0;
> } else if (eq_margin(ev.duration, NEC_REPEAT_SPACE, NEC_UNIT / 2)) {
>
The timings above are adjusted for 9000us/4500us, with a tolerance of 281,250us.
You're changing the pulse tolerance to 1125us for pulse, and 562,5us for space.
I double-checked: this shouldn't interfere with the other decoders, so it could
be possible to apply it, without causing regressions.
I'll apply it.
Regards,
Mauro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-11 20:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-31 10:37 [PATCH] [media] nec-decoder: fix NEC decoding for Pioneer Laserdisc CU-700 remote Sean Young
2012-08-11 20:31 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).