Re: [PATCH] em28xx: Fix height setting on non-progressive captures

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 03-08-2012 14:52, Ezequiel Garcia escreveu:
> This was introduced on commit c2a6b54a9:
> "em28xx: fix: don't do image interlacing on webcams"
> It is a known bug that has already been reported several times
> and confirmed by Mauro.

Thanks for reminding us about that.

> Tested by compilation only.
> 
> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
> ---
> Hi,
> 
> I have no idea why this hasn't been fixed before.

The reason was because that patch didn't work ;)

> 
> See this mail for Mauro's confirmation
> http://www.digipedia.pl/usenet/thread/18550/7691/#post7685
> where he requested a patch on reporter. 
> 
> I guess the patch never came in.


Did some tests here with both TV and Webcam (progressive)
devices. The enclosed patch fixes the issue.

Regards,
Mauro.

[media] em28xx: Fix height setting on non-progressive captures

This was introduced on commit c2a6b54a9:
"em28xx: fix: don't do image interlacing on webcams"

The proposed patch by Ezequiel is wrong. The right fix here is to just
don't bother here if either the image is progressive or not.

Reported-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/video/em28xx/em28xx-core.c b/drivers/media/video/em28xx/em28xx-core.c
index de2cb20..bed07a6 100644
--- a/drivers/media/video/em28xx/em28xx-core.c
+++ b/drivers/media/video/em28xx/em28xx-core.c
@@ -785,12 +785,8 @@ int em28xx_resolution_set(struct em28xx *dev)
 	else
 		dev->vbi_height = 18;
 
-	if (!dev->progressive)
-		height >>= norm_maxh(dev);
-
 	em28xx_set_outfmt(dev);
 
-
 	em28xx_accumulator_set(dev, 1, (width - 4) >> 2, 1, (height - 4) >> 2);
 
 	/* If we don't set the start position to 2 in VBI mode, we end up