Re: [PATCH] staging: media: cxd2099: remove memcpy of similar structure variables

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 06-08-2012 07:40, Ezequiel Garcia escreveu:
> On Mon, Aug 6, 2012 at 2:28 AM, Devendra Naga
> <develkernel412222@gmail.com> wrote:
>> Hi Ezequiel,
>>
>> On Mon, Aug 6, 2012 at 3:36 AM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
>>> Hi Devendra,
>>>
>>> Thanks for the patch,
>>>
>>> On Sun, Aug 5, 2012 at 5:40 PM, Devendra Naga
>>> <develkernel412222@gmail.com> wrote:
>>>> structure variables can be assigned, no memcpy needed,
>>>> remove the memcpy and use assignment for the cfg and en variables.
>>>>
>>>> Tested by Compilation Only
>>>>
>>>> Suggested-by: Ezequiel Garcia <elezegarcia@gmail.com>
>>>
>>> I'm not sure this is completely valid or useful.
>>>
>>> If you read Documentation/SubmittingPatches (which you should)
>>> you will find references to Acked-by, Reported-by, Tested-by,
>>> but not this one.
>>>
>>> You don't need to give me credit for the patch:
>>> it's *your* patch, all I did was a very simple suggestion :-)
>>>
>> Ok. I will remove the Suggested-by line and send out the patch again
>> with PATCH RESEND subject line.
>> Is it ok?
>>
> 
> I'm not entirely sure. Perhaps you can leave it as it is, and let
> Mauro remove that line.

I prefer keeping it, to preserve this patch history.

Regards,
Mauro