From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59035 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750802Ab2HLKat (ORCPT ); Sun, 12 Aug 2012 06:30:49 -0400 Message-ID: <502785CA.6000907@redhat.com> Date: Sun, 12 Aug 2012 07:30:34 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Ezequiel Garcia CC: Devendra Naga , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, Mauro Carvalho Chehab Subject: Re: [PATCH] staging: media: cxd2099: remove memcpy of similar structure variables References: <1344199202-15744-1-git-send-email-develkernel412222@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em 06-08-2012 07:40, Ezequiel Garcia escreveu: > On Mon, Aug 6, 2012 at 2:28 AM, Devendra Naga > wrote: >> Hi Ezequiel, >> >> On Mon, Aug 6, 2012 at 3:36 AM, Ezequiel Garcia wrote: >>> Hi Devendra, >>> >>> Thanks for the patch, >>> >>> On Sun, Aug 5, 2012 at 5:40 PM, Devendra Naga >>> wrote: >>>> structure variables can be assigned, no memcpy needed, >>>> remove the memcpy and use assignment for the cfg and en variables. >>>> >>>> Tested by Compilation Only >>>> >>>> Suggested-by: Ezequiel Garcia >>> >>> I'm not sure this is completely valid or useful. >>> >>> If you read Documentation/SubmittingPatches (which you should) >>> you will find references to Acked-by, Reported-by, Tested-by, >>> but not this one. >>> >>> You don't need to give me credit for the patch: >>> it's *your* patch, all I did was a very simple suggestion :-) >>> >> Ok. I will remove the Suggested-by line and send out the patch again >> with PATCH RESEND subject line. >> Is it ok? >> > > I'm not entirely sure. Perhaps you can leave it as it is, and let > Mauro remove that line. I prefer keeping it, to preserve this patch history. Regards, Mauro