Re: [git:v4l-dvb/for_v3.7] [media] mantis: Terratec Cinergy C PCI HD (CI)

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 10-08-2012 20:55, Manu Abraham escreveu:
> Mauro,
> 
> Please revert this patch. Patch is incorrect. There is the VP-20300,
> VP-20330, VP-2040, with differences in tuner types TDA10021, TDA10023,
> MK-I, MK-II and MK-III. I have detailed this issue in an earlier mail.
> Terratec Cinregy C is VP-2033 and not VP-2040.

Well, as I don't have this board, you think that it is a VP-2033 while
Igor thinks it is a VP-2040, I can't tell who is right on that.

I need either you to change your mind or to get a third developer to
point who is right in order to address it.

In any case, no harm is done, as both have exactly the same code.

That's why the better is to just drop one of the drivers, while
both are identical.

Regards,
Mauro

> 
> Thanks!
> 
> 
> On Sat, Aug 11, 2012 at 1:34 AM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
>> This is an automatic generated email to let you know that the following patch were queued at the
>> http://git.linuxtv.org/media_tree.git tree:
>>
>> Subject: [media] mantis: Terratec Cinergy C PCI HD (CI)
>> Author:  Igor M. Liplianin <liplianin@me.by>
>> Date:    Wed May 9 07:23:14 2012 -0300
>>
>> This patch seems for rectifying a typo. But actually the difference between
>> mantis_vp2040.c and mantis_vp2033.c code is a card name only.
>>
>> Signed-off-by: Igor M. Liplianin <liplianin@me.by>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>>
>>  drivers/media/dvb/mantis/mantis_cards.c |    2 +-
>>  drivers/media/dvb/mantis/mantis_core.c  |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> ---
>>
>> http://git.linuxtv.org/media_tree.git?a=commitdiff;h=9fa4d6a102ebb06663a03554b57fb93ad618b72e
>>
>> diff --git a/drivers/media/dvb/mantis/mantis_cards.c b/drivers/media/dvb/mantis/mantis_cards.c
>> index 095cf3a..0207d1f 100644
>> --- a/drivers/media/dvb/mantis/mantis_cards.c
>> +++ b/drivers/media/dvb/mantis/mantis_cards.c
>> @@ -275,7 +275,7 @@ static struct pci_device_id mantis_pci_table[] = {
>>         MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_2033_DVB_C, &vp2033_config),
>>         MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_2040_DVB_C, &vp2040_config),
>>         MAKE_ENTRY(TECHNISAT, CABLESTAR_HD2, &vp2040_config),
>> -       MAKE_ENTRY(TERRATEC, CINERGY_C, &vp2033_config),
>> +       MAKE_ENTRY(TERRATEC, CINERGY_C, &vp2040_config),
>>         MAKE_ENTRY(TWINHAN_TECHNOLOGIES, MANTIS_VP_3030_DVB_T, &vp3030_config),
>>         { }
>>  };
>> diff --git a/drivers/media/dvb/mantis/mantis_core.c b/drivers/media/dvb/mantis/mantis_core.c
>> index 22524a8..684d906 100644
>> --- a/drivers/media/dvb/mantis/mantis_core.c
>> +++ b/drivers/media/dvb/mantis/mantis_core.c
>> @@ -121,7 +121,7 @@ static void mantis_load_config(struct mantis_pci *mantis)
>>                 mantis->hwconfig = &vp2033_mantis_config;
>>                 break;
>>         case MANTIS_VP_2040_DVB_C:      /* VP-2040 */
>> -       case TERRATEC_CINERGY_C_PCI:    /* VP-2040 clone */
>> +       case CINERGY_C: /* VP-2040 clone */
>>         case TECHNISAT_CABLESTAR_HD2:
>>                 mantis->hwconfig = &vp2040_mantis_config;
>>                 break;
>>
>> _______________________________________________
>> linuxtv-commits mailing list
>> linuxtv-commits@linuxtv.org
>> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>