From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Manu Abraham <abraham.manu@gmail.com>
Cc: "Igor M. Liplianin" <liplianin@me.by>,
linux-media@vger.kernel.org, linuxtv-commits@linuxtv.org
Subject: Re: [git:v4l-dvb/for_v3.7] [media] mantis: Terratec Cinergy C PCI HD (CI)
Date: Tue, 14 Aug 2012 10:23:05 -0300 [thread overview]
Message-ID: <502A5139.8080402@redhat.com> (raw)
In-Reply-To: <CAHFNz9+qWXYkvJXeZfSu2DgAQ3BrsX591TS5x+XeEOVji3Hx2g@mail.gmail.com>
Em 14-08-2012 04:45, Manu Abraham escreveu:
> On Tue, Aug 14, 2012 at 12:55 AM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
>> Em 10-08-2012 20:55, Manu Abraham escreveu:
>>> Mauro,
>>>
>>> Please revert this patch. Patch is incorrect. There is the VP-20300,
>>> VP-20330, VP-2040, with differences in tuner types TDA10021, TDA10023,
>>> MK-I, MK-II and MK-III. I have detailed this issue in an earlier mail.
>>> Terratec Cinregy C is VP-2033 and not VP-2040.
>>
>> Well, as I don't have this board, you think that it is a VP-2033 while
>> Igor thinks it is a VP-2040, I can't tell who is right on that.
>
> You don't need all the cards to apply changes, that's how the Linux
> patchland works.
>
> I have "all" Mantis based devices here. So I can say with clarity that
> Terratec Cinergy C is VP-2033. I authored the whole driver for the
> chipset manufacturer and the card manufacturer and still in touch with
> all of them and pretty sure what is what.
>
> Any idiot can send any patch, that's why you need to ask the persons
> who added particular changes in that area.
Yes, you authored the driver, but that doesn't necessarily means that
you'll have all clones of VP-2033/VP-2040.
> Do you want me to add
> myself to MAINTAINERS to make it a bit more clearer, if that's what
> you prefer ?
If you're wiling to maintain it, not holding patches for more than the
few days required for their review, then YES!!!
Please add yourself to the MAINTAINERS for the drivers you're willing
to maintain and submit me such patch for upstream merging.
> Please revert this change.
I'll do.
Regards,
Mauro
next prev parent reply other threads:[~2012-08-14 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1SzvhW-0005hd-1S@www.linuxtv.org>
2012-08-10 23:55 ` [git:v4l-dvb/for_v3.7] [media] mantis: Terratec Cinergy C PCI HD (CI) Manu Abraham
2012-08-13 19:25 ` Mauro Carvalho Chehab
2012-08-14 7:45 ` Manu Abraham
2012-08-14 13:23 ` Mauro Carvalho Chehab [this message]
2012-08-14 13:31 ` Mauro Carvalho Chehab
2012-08-16 13:39 ` Bjørn Mork
2012-08-16 13:49 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502A5139.8080402@redhat.com \
--to=mchehab@redhat.com \
--cc=abraham.manu@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linuxtv-commits@linuxtv.org \
--cc=liplianin@me.by \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).