From: Reinhard Nissl <rnissl@gmx.de>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Manu Abraham <abraham.manu@gmail.com>, linux-media@vger.kernel.org
Subject: Re: STV0299: reading property DTV_FREQUENCY -- what am I expected to get?
Date: Sat, 18 Aug 2012 14:59:57 +0200 [thread overview]
Message-ID: <502F91CD.4070507@gmx.de> (raw)
In-Reply-To: <502C1E53.4090103@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
Hi,
Am 16.08.2012 00:10, schrieb Mauro Carvalho Chehab:
> The patch seems to be working. Anyway, for it to be merged, you'll
> need to be sending it together with your SOB (Signed-off-by),
> and using the -p1 format e. g. something like:
>
> --- a/drivers/media/dvb/frontends/stb0899_drv.c 2012-08-14 21:59:59.000000000 +0200
> +++ b/drivers/media/dvb/frontends/stb0899_drv.c 2012-08-14 21:29:17.000000000 +0200
>
> as otherwise developer's scripts won't get it right.
I hope I got it right this time ;-)
Bye.
--
Dipl.-Inform. (FH) Reinhard Nissl
mailto:rnissl@gmx.de
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: stb0899_drv-report-internal-freq-via-get_frontend-git.diff --]
[-- Type: text/x-patch; name="stb0899_drv-report-internal-freq-via-get_frontend-git.diff", Size: 555 bytes --]
stb0899: return internally tuned frequency via get_frontend.
Signed-off-by: Reinhard Nißl <rnissl@gmx.de>
diff --git a/drivers/media/dvb-frontends/stb0899_drv.c b/drivers/media/dvb-frontends/stb0899_drv.c
index 5d7f8a9..79e29de 100644
--- a/drivers/media/dvb-frontends/stb0899_drv.c
+++ b/drivers/media/dvb-frontends/stb0899_drv.c
@@ -1563,6 +1563,7 @@ static int stb0899_get_frontend(struct dvb_frontend *fe)
dprintk(state->verbose, FE_DEBUG, 1, "Get params");
p->symbol_rate = internal->srate;
+ p->frequency = internal->freq;
return 0;
}
prev parent reply other threads:[~2012-08-18 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 8:53 STV0299: reading property DTV_FREQUENCY -- what am I expected to get? Reinhard Nissl
2012-08-14 11:10 ` Antti Palosaari
2012-08-14 12:05 ` Manu Abraham
2012-08-14 20:15 ` Reinhard Nissl
2012-08-15 14:41 ` Reinhard Nissl
2012-08-15 22:10 ` Mauro Carvalho Chehab
2012-08-18 12:59 ` Reinhard Nissl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502F91CD.4070507@gmx.de \
--to=rnissl@gmx.de \
--cc=abraham.manu@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).