From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 4/6] [media] Cleanup media Kconfig files
Date: Tue, 21 Aug 2012 08:01:01 -0300 [thread overview]
Message-ID: <50336A6D.8030106@redhat.com> (raw)
In-Reply-To: <CAK9yfHzbL0QKoEx9YWdRSczN3jPCzUzpDnoOXN7tFmogL0HpLg@mail.gmail.com>
Em 21-08-2012 00:41, Sachin Kamat escreveu:
> Hi Mauro,
>
> On 20 August 2012 23:52, Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
>> - get rid of ridden V4L2_COMMON symbol
>>
>> This symbol is not needed anymore; it can be folded with V4L2
>> one, simplifying the Kconfig a little bit;
>>
>> - Comment why some Kconfig items are needed;
>>
>> - Remove if test for MEDIA_CAMERA_SUPPORT, replacing it by
>> depends on.
>>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>> ---
>> drivers/media/Kconfig | 5 -----
>> drivers/media/i2c/Kconfig | 2 +-
>> drivers/media/platform/Kconfig | 6 ++----
>> drivers/media/v4l2-core/Kconfig | 27 ++++++++++++++++-----------
>> drivers/media/v4l2-core/Makefile | 2 +-
>> 5 files changed, 20 insertions(+), 22 deletions(-)
>>
>> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
>> index d5b4e72..9c3698a 100644
>> --- a/drivers/media/Kconfig
>> +++ b/drivers/media/Kconfig
>> @@ -99,11 +99,6 @@ config VIDEO_DEV
>> depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT
>> default y
>>
>> -config VIDEO_V4L2_COMMON
>> - tristate
>> - depends on (I2C || I2C=n) && VIDEO_DEV
>> - default (I2C || I2C=n) && VIDEO_DEV
>> -
>> config VIDEO_V4L2_SUBDEV_API
>> bool "V4L2 sub-device userspace API (EXPERIMENTAL)"
>> depends on VIDEO_DEV && MEDIA_CONTROLLER && EXPERIMENTAL
>> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
>> index 7fe4acf..ad2c9de 100644
>> --- a/drivers/media/i2c/Kconfig
>> +++ b/drivers/media/i2c/Kconfig
>> @@ -322,7 +322,7 @@ comment "MPEG video encoders"
>>
>> config VIDEO_CX2341X
>> tristate "Conexant CX2341x MPEG encoders"
>> - depends on VIDEO_V4L2 && VIDEO_V4L2_COMMON
>> + depends on VIDEO_V4L2 && VIDEO_V4L2
>
> VIDEO_V4L2 is duplicated.
Indeed. That's the problem with scripted patches ;)
Well, the original statement there sucks, as, before this patch,
VIDEO_V4L2_COMMON was a requirement for VIDEO_V4L2.
I suspect that there are lots of duplicated dependencies like
the above all over the Kconfigs.
For example, I suspect it is possible to get merge both VIDEO_DEV
and VIDEO_V4L2, but cleaning those Kconfig symbols will
require some time and patience.
Regards,
Mauro
next prev parent reply other threads:[~2012-08-21 11:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 18:22 [PATCH 0/6] media reorganization - part 3 Mauro Carvalho Chehab
2012-08-20 18:22 ` [PATCH 1/6] [media] move soc_camera to its own directory Mauro Carvalho Chehab
2012-08-20 19:32 ` Guennadi Liakhovetski
2012-08-20 20:10 ` Mauro Carvalho Chehab
2012-08-21 22:01 ` Guennadi Liakhovetski
2012-08-20 18:22 ` [PATCH 2/6] [media] Kconfig reorganization Mauro Carvalho Chehab
2012-08-20 18:22 ` [PATCH 3/6] [media] Put the test devices together Mauro Carvalho Chehab
2012-08-20 18:22 ` [PATCH 4/6] [media] Cleanup media Kconfig files Mauro Carvalho Chehab
2012-08-21 3:41 ` Sachin Kamat
2012-08-21 11:01 ` Mauro Carvalho Chehab [this message]
2012-08-20 18:22 ` [PATCH 5/6] [media] Kconfig: use menuconfig instead of menu Mauro Carvalho Chehab
2012-08-20 18:22 ` [PATCH 6/6] [media] Kconfig: merge all customise options into just one Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50336A6D.8030106@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).