linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-media@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media/radio/shark2: Fix build error caused by missing dependencies
Date: Wed, 22 Aug 2012 17:22:26 +0200	[thread overview]
Message-ID: <5034F932.4000405@redhat.com> (raw)
In-Reply-To: <1345648585-5176-1-git-send-email-linux@roeck-us.net>

Hi,

I've a better fix for this here:
http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.6

I already send a pull-req for this to Mauro a while ago, Mauro?

Regards,

Hans

On 08/22/2012 05:16 PM, Guenter Roeck wrote:
> Fix build error:
>
> ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined!
> ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined!
>
> which is seen if RADIO_SHARK2 is enabled, but LEDS_CLASS is not.
>
> Since RADIO_SHARK2 depends on NEW_LEDS and LEDS_CLASS, select both if
> it is enabled.
>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>   drivers/media/radio/Kconfig |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
> index 8090b87..bee4bee 100644
> --- a/drivers/media/radio/Kconfig
> +++ b/drivers/media/radio/Kconfig
> @@ -77,6 +77,8 @@ config RADIO_SHARK
>   config RADIO_SHARK2
>   	tristate "Griffin radioSHARK2 USB radio receiver"
>   	depends on USB
> +	select NEW_LEDS
> +	select LEDS_CLASS
>   	---help---
>   	  Choose Y here if you have this radio receiver.
>
>

  reply	other threads:[~2012-08-22 15:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22 15:16 [PATCH] media/radio/shark2: Fix build error caused by missing dependencies Guenter Roeck
2012-08-22 15:22 ` Hans de Goede [this message]
2012-08-22 15:29   ` Guenter Roeck
2012-08-22 18:57     ` Arnd Bergmann
2012-08-23 10:05       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5034F932.4000405@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).