From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11340 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757554Ab2HVPWB (ORCPT ); Wed, 22 Aug 2012 11:22:01 -0400 Message-ID: <5034F932.4000405@redhat.com> Date: Wed, 22 Aug 2012 17:22:26 +0200 From: Hans de Goede MIME-Version: 1.0 To: Guenter Roeck CC: linux-media@vger.kernel.org, Mauro Carvalho Chehab , linux-kernel@vger.kernel.org Subject: Re: [PATCH] media/radio/shark2: Fix build error caused by missing dependencies References: <1345648585-5176-1-git-send-email-linux@roeck-us.net> In-Reply-To: <1345648585-5176-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi, I've a better fix for this here: http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.6 I already send a pull-req for this to Mauro a while ago, Mauro? Regards, Hans On 08/22/2012 05:16 PM, Guenter Roeck wrote: > Fix build error: > > ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined! > ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined! > > which is seen if RADIO_SHARK2 is enabled, but LEDS_CLASS is not. > > Since RADIO_SHARK2 depends on NEW_LEDS and LEDS_CLASS, select both if > it is enabled. > > Cc: Hans de Goede > Signed-off-by: Guenter Roeck > --- > drivers/media/radio/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig > index 8090b87..bee4bee 100644 > --- a/drivers/media/radio/Kconfig > +++ b/drivers/media/radio/Kconfig > @@ -77,6 +77,8 @@ config RADIO_SHARK > config RADIO_SHARK2 > tristate "Griffin radioSHARK2 USB radio receiver" > depends on USB > + select NEW_LEDS > + select LEDS_CLASS > ---help--- > Choose Y here if you have this radio receiver. > >