[PATCH] media/radio/shark2: Fix build error caused by missing dependencies

[PATCH] media/radio/shark2: Fix build error caused by missing dependencies

[Guenter Roeck]

Fix build error:

ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined!
ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined!

which is seen if RADIO_SHARK2 is enabled, but LEDS_CLASS is not.

Since RADIO_SHARK2 depends on NEW_LEDS and LEDS_CLASS, select both if
it is enabled.

Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/media/radio/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
index 8090b87..bee4bee 100644
--- a/drivers/media/radio/Kconfig
+++ b/drivers/media/radio/Kconfig
@@ -77,6 +77,8 @@ config RADIO_SHARK
 config RADIO_SHARK2
 	tristate "Griffin radioSHARK2 USB radio receiver"
 	depends on USB
+	select NEW_LEDS
+	select LEDS_CLASS
 	---help---
 	  Choose Y here if you have this radio receiver.
 
-- 
1.7.9.7

Re: [PATCH] media/radio/shark2: Fix build error caused by missing dependencies

[Hans de Goede]

Hi,

I've a better fix for this here:
http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.6

I already send a pull-req for this to Mauro a while ago, Mauro?

Regards,

Hans

On 08/22/2012 05:16 PM, Guenter Roeck wrote:
> Fix build error:
>
> ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined!
> ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined!
>
> which is seen if RADIO_SHARK2 is enabled, but LEDS_CLASS is not.
>
> Since RADIO_SHARK2 depends on NEW_LEDS and LEDS_CLASS, select both if
> it is enabled.
>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>   drivers/media/radio/Kconfig |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
> index 8090b87..bee4bee 100644
> --- a/drivers/media/radio/Kconfig
> +++ b/drivers/media/radio/Kconfig
> @@ -77,6 +77,8 @@ config RADIO_SHARK
>   config RADIO_SHARK2
>   	tristate "Griffin radioSHARK2 USB radio receiver"
>   	depends on USB
> +	select NEW_LEDS
> +	select LEDS_CLASS
>   	---help---
>   	  Choose Y here if you have this radio receiver.
>
>

Re: [PATCH] media/radio/shark2: Fix build error caused by missing dependencies

[Guenter Roeck]

On Wed, Aug 22, 2012 at 05:22:26PM +0200, Hans de Goede wrote:
> Hi,
> 
> I've a better fix for this here:
> http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.6
> 
> I already send a pull-req for this to Mauro a while ago, Mauro?
> 
Looks like it found its way into mainline in the last couple of days.
Should have updated my tree first. Sorry for the noise.

Guenter

Re: [PATCH] media/radio/shark2: Fix build error caused by missing dependencies

[Arnd Bergmann]

On Wednesday 22 August 2012, Guenter Roeck wrote:
> On Wed, Aug 22, 2012 at 05:22:26PM +0200, Hans de Goede wrote:
> > Hi,
> > 
> > I've a better fix for this here:
> > http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.6
> > 
> > I already send a pull-req for this to Mauro a while ago, Mauro?
> > 
> Looks like it found its way into mainline in the last couple of days.
> Should have updated my tree first. Sorry for the noise.
> 

I found another issue with the shark driver while doing randconfig tests.
Here is my semi-automated log file for the problem. Has this also made
it in already?

	Arnd

---
Without this patch, building rand-0y2jSKT results in:

WARNING: drivers/usb/musb/musb_hdrc.o(.devinit.text+0x9b8): Section mismatch in reference from the function musb_init_controller() to the function .init.text:dma_controller_create()
The function __devinit musb_init_controller() references
a function __init dma_controller_create().
If dma_controller_create is only used by musb_init_controller then
annotate dma_controller_create with a matching annotation.

ERROR: "snd_tea575x_init" [drivers/media/radio/radio-shark.ko] undefined!
ERROR: "snd_tea575x_exit" [drivers/media/radio/radio-shark.ko] undefined!
make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [sub-make] Error 2

---
 sound/pci/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
index ff3af6e..f99fa25 100644
--- a/sound/pci/Kconfig
+++ b/sound/pci/Kconfig
@@ -2,8 +2,8 @@
 
 config SND_TEA575X
 	tristate
-	depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2 || RADIO_MAXIRADIO
-	default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2 || RADIO_MAXIRADIO
+	depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2 || RADIO_MAXIRADIO || RADIO_SHARK
+	default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2 || RADIO_MAXIRADIO || RADIO_SHARK
 
 menuconfig SND_PCI
 	bool "PCI sound devices"
-- 
1.7.10

Re: [PATCH] media/radio/shark2: Fix build error caused by missing dependencies

[Hans de Goede]

Hi,

On 08/22/2012 08:57 PM, Arnd Bergmann wrote:
> On Wednesday 22 August 2012, Guenter Roeck wrote:
>> On Wed, Aug 22, 2012 at 05:22:26PM +0200, Hans de Goede wrote:
>>> Hi,
>>>
>>> I've a better fix for this here:
>>> http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.6
>>>
>>> I already send a pull-req for this to Mauro a while ago, Mauro?
>>>
>> Looks like it found its way into mainline in the last couple of days.
>> Should have updated my tree first. Sorry for the noise.
>>
>
> I found another issue with the shark driver while doing randconfig tests.
> Here is my semi-automated log file for the problem. Has this also made
> it in already?

No,

Mauro, can you please add Arnd's fix for this to 3.6 ?

Thanks,

Hans