From: Antti Palosaari <crope@iki.fi>
To: Andy Walls <awalls@md.metrocast.net>,
Julia Lawall <julia.lawall@lip6.fr>
Cc: mchehab@infradead.org, linux-media@vger.kernel.org
Subject: Re: question about drivers/media/dvb-frontends/rtl2830.c
Date: Sun, 26 Aug 2012 19:06:32 +0300 [thread overview]
Message-ID: <503A4988.70205@iki.fi> (raw)
In-Reply-To: <c67025bd-4c41-462f-88ee-b534b733d320@email.android.com>
On 08/26/2012 02:20 PM, Andy Walls wrote:
> Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>> The function rtl2830_init contains the code:
>>
>> buf[0] = tmp << 6;
>> buf[0] = (if_ctl >> 16) & 0x3f;
>> buf[1] = (if_ctl >> 8) & 0xff;
>> buf[2] = (if_ctl >> 0) & 0xff;
>>
>> Is there any purpose to initializing buf[0] twice?
>>
>> julia
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media"
>> in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Hmm. Since 0x3f is the lowest 6 bits, it looks like the second line should use |= instead of = . I don't know anything about the rt2830 though.
>
> -Andy
Andy is correct. If you look few lines just before that you could see
that logic. Patch is welcome.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2012-08-26 16:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 7:25 question about drivers/media/dvb-frontends/rtl2830.c Julia Lawall
2012-08-26 11:20 ` Andy Walls
2012-08-26 16:06 ` Antti Palosaari [this message]
2012-08-26 16:16 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503A4988.70205@iki.fi \
--to=crope@iki.fi \
--cc=awalls@md.metrocast.net \
--cc=julia.lawall@lip6.fr \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).