From: Antti Palosaari <crope@iki.fi>
To: Jose Alberto Reguero <jareguero@telefonica.net>
Cc: linux-media@vger.kernel.org, Michael Krufky <mkrufky@linuxtv.org>
Subject: Re: [PATCH] Add support to Avermedia Twinstar double tuner in af9035
Date: Sun, 26 Aug 2012 19:45:49 +0300 [thread overview]
Message-ID: <503A52BD.90603@iki.fi> (raw)
In-Reply-To: <1535656.ZrASkjgG1J@jar7.dominio>
On 08/25/2012 10:05 PM, Jose Alberto Reguero wrote:
> This patch add support to the Avermedia Twinstar double tuner in the
> af9035 driver.
>
> This time the patch inline because it was rejected. Also patch was
> malformed.
>
> Signed-off-by: Jose Alberto Reguero <jareguero@telefonica.net
> <mailto:jareguero@telefonica.net>>
>
> Jose Alberto
Hello Jose, and thank you very much to hack this important and missing
piece of AF9035 driver functionality.
I looked it quickly and here is the comments so far. I will try to
review it more carefully tomorrow.
* your patch is very hard to read/review as you used some diff option
that does not show function name whom code is changed
* there is two new configuration parameters for af9033 demod. I don't
understand why. As I don't see any need / use for those I want you to
remove those. Configurations structures are something not to add any
extra parameters "just for fun". Use "ts_mode != AF9033_TS_MODE_USB"
instead of "second". Other parameter "tuner_address" is not used at all
for af9033.
* MXL5007T is not my driver. There seems to be new parameters no_probe
and no_reset. Those sounds also something that could be avoided. But I
didn't looked that code and I am not sure. Add at least comment why
those are used as such parameters deviates from normal use.
Could you also sent small sniff for me where is dual tuner used?
regards
Antti
--
http://palosaari.fi/
parent reply other threads:[~2012-08-26 16:46 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1535656.ZrASkjgG1J@jar7.dominio>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503A52BD.90603@iki.fi \
--to=crope@iki.fi \
--cc=jareguero@telefonica.net \
--cc=linux-media@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).