linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anders Thomson <aeriksson2@gmail.com>
To: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: tda8290 regression fix
Date: Thu, 30 Aug 2012 13:27:21 +0200	[thread overview]
Message-ID: <503F4E19.1050700@gmail.com> (raw)

Hi,

Ever since 2.6.26 or so (where there was a code reorg) I had to carry 
this patch.
Without it the received signal is noisy, and the card worked fine prior 
to the code
reorg. This patch is a hack, mostly as a result of my inability to 
follow the code
paths (and bisect failing). I'd be more than willing to test whatever 
the proper
patch might be prior to any mainlining.

Thanks,
/Anders



$ cat /TV_CARD.diff
diff --git a/drivers/media/common/tuners/tda8290.c 
b/drivers/media/common/tuners/tda8290.c
index 064d14c..498cc7b 100644
--- a/drivers/media/common/tuners/tda8290.c
+++ b/drivers/media/common/tuners/tda8290.c
@@ -635,7 +635,11 @@ static int tda829x_find_tuner(struct dvb_frontend *fe)

                 dvb_attach(tda827x_attach, fe, priv->tda827x_addr,
                            priv->i2c_props.adap, &priv->cfg);
+               tuner_info("ANDERS: setting switch_addr. was 0x%02x, new 
0x%02x\n",priv->cfg.switch_addr,priv->i2c_props.addr);
                 priv->cfg.switch_addr = priv->i2c_props.addr;
+               priv->cfg.switch_addr = 0xc2 / 2;
+               tuner_info("ANDERS: new 0x%02x\n",priv->cfg.switch_addr);
+
         }
         if (fe->ops.tuner_ops.init)
                 fe->ops.tuner_ops.init(fe);


             reply	other threads:[~2012-08-30 11:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-30 11:27 Anders Thomson [this message]
2012-09-15 16:34 ` tda8290 regression fix Mauro Carvalho Chehab
2012-09-15 17:39   ` Anders Thomson
2012-09-15 17:44     ` Anders Thomson
2012-09-15 17:58     ` Mauro Carvalho Chehab
2012-09-15 18:12       ` Anders Thomson
2012-09-15 22:25         ` Mauro Carvalho Chehab
2012-09-16  8:48           ` Anders Thomson
2012-09-18  9:53             ` Mauro Carvalho Chehab
2012-09-19 13:01               ` Anders Thomson
2012-09-19 16:45                 ` Mauro Carvalho Chehab
2012-09-19 19:25                   ` Anders Thomson
     [not found]                     ` <CAGncdOae+VoAAUWz3x84zUA-TCMeMmNONf_ktNFd1p7c-o5H_A@mail.gmail.com>
2012-09-21 14:49                       ` Mauro Carvalho Chehab
     [not found]                         ` <8ed8c988-fa8c-41fc-9f33-cccdceb1b232@email.android.com>
2012-09-23 11:36                           ` Mauro Carvalho Chehab
2012-09-23 17:54                             ` Anders Thomson
2012-09-23 18:14                               ` Mauro Carvalho Chehab
2012-09-23 18:39                               ` Anders Thomson
2012-09-23 21:06                                 ` Anders Thomson
2012-10-01 16:56                                   ` Anders Thomson
2012-11-15 20:43                                     ` Anders Thomson
2012-12-04 11:00                                       ` Anders Thomson
2012-09-15 18:28       ` Anders Thomson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503F4E19.1050700@gmail.com \
    --to=aeriksson2@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).