From: poma <pomidorabelisima@gmail.com>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org,
Thomas Mair <thomas.mair86@googlemail.com>,
David Basden <davidb-git@rcpt.to>,
Zdenek Styblik <stybla@turnovfree.net>,
Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: Re: [PATCH 2/5] rtl28xxu: fix rtl2832u module reload fails bug
Date: Sat, 01 Sep 2012 15:54:19 +0200 [thread overview]
Message-ID: <5042138B.4080109@gmail.com> (raw)
In-Reply-To: <1345593382-11367-2-git-send-email-crope@iki.fi>
On 08/22/2012 01:56 AM, Antti Palosaari wrote:
> This is workaround / partial fix.
>
> rtl2832u_power_ctrl() and rtl2832u_frontend_attach() needs to
> be go through carefully and fix properly. There is clearly
> some logical errors when handling power-management ang GPIOs...
>
> Signed-off-by: Antti Palosaari <crope@iki.fi>
> Cc: Thomas Mair <thomas.mair86@googlemail.com>
> ---
> drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
> index 1ccb99b..c246c50 100644
> --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
> +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
> @@ -946,17 +946,6 @@ static int rtl2832u_power_ctrl(struct dvb_usb_device *d, int onoff)
> if (ret)
> goto err;
>
> - /* demod HW reset */
> - ret = rtl28xx_rd_reg(d, SYS_DEMOD_CTL, &val);
> - if (ret)
> - goto err;
> - /* bit 5 to 0 */
> - val &= 0xdf;
> -
> - ret = rtl28xx_wr_reg(d, SYS_DEMOD_CTL, val);
> - if (ret)
> - goto err;
> -
> ret = rtl28xx_rd_reg(d, SYS_DEMOD_CTL, &val);
> if (ret)
> goto err;
>
Test: PASSED!
Working zapping on every hard/cold boot, soft/warm [re]boot and every
module(dvb_usb_rtl28xxu) [re]load.
Outside the box thinking!
Antti, thank you very much!
media_build
commit 420335f564c32517a791ecea3909af233925634d
1f4d:b803 G-Tek Electronics Group Lifeview LV5TDLX DVB-T [RTL2832U]
Cheers,
poma
next prev parent reply other threads:[~2012-09-01 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 23:56 [PATCH 1/5] rtl28xxu: stream did not start after stop on USB3.0 Antti Palosaari
2012-08-21 23:56 ` [PATCH 2/5] rtl28xxu: fix rtl2832u module reload fails bug Antti Palosaari
2012-09-01 13:54 ` poma [this message]
2012-08-21 23:56 ` [PATCH 3/5] rtl2832: implement .get_frontend() Antti Palosaari
2012-08-21 23:56 ` [PATCH 4/5] rtl2832: implement .read_snr() Antti Palosaari
2012-08-21 23:56 ` [PATCH 5/5] rtl2832: implement .read_ber() Antti Palosaari
2012-09-01 13:33 ` [PATCH 1/5] rtl28xxu: stream did not start after stop on USB3.0 poma
2012-09-01 13:50 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5042138B.4080109@gmail.com \
--to=pomidorabelisima@gmail.com \
--cc=crope@iki.fi \
--cc=davidb-git@rcpt.to \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=stybla@turnovfree.net \
--cc=thomas.mair86@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).