From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Prabhakar Lad <prabhakar.lad@ti.com>
Cc: LMML <linux-media@vger.kernel.org>,
dlos <davinci-linux-open-source@linux.davincidsp.com>,
linux-kernel@vger.kernel.org,
Manjunath Hadli <manjunath.hadli@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-doc@vger.kernel.org, Sakari Ailus <sakari.ailus@iki.fi>,
Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Hans de Goede <hdegoede@redhat.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Rob Landley <rob@landley.net>
Subject: Re: [PATCH] media: v4l2-ctrls: add control for test pattern
Date: Mon, 03 Sep 2012 11:25:53 +0200 [thread overview]
Message-ID: <504477A1.6020304@samsung.com> (raw)
In-Reply-To: <1346663777-23149-1-git-send-email-prabhakar.lad@ti.com>
On 09/03/2012 11:16 AM, Prabhakar Lad wrote:
> diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c
> index 2d7bc15..ae709d1 100644
> --- a/drivers/media/v4l2-core/v4l2-ctrls.c
> +++ b/drivers/media/v4l2-core/v4l2-ctrls.c
> @@ -430,6 +430,18 @@ const char * const *v4l2_ctrl_get_menu(u32 id)
> "Advanced Predictor",
> NULL,
> };
> + static const char * const test_pattern[] = {
> + "Test Pattern Disabled",
How about just "Disabled" ?
> + "Vertical Lines",
> + "Horizontal Lines",
> + "Diagonal Lines",
> + "Solid Black",
> + "Solid White",
> + "Solid Blue",
> + "Solid Red",
> + "Checker Board",
> + NULL,
> + };
--
Regards,
Sylwester
next prev parent reply other threads:[~2012-09-03 9:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 9:16 [PATCH] media: v4l2-ctrls: add control for test pattern Prabhakar Lad
2012-09-03 9:22 ` Hans Verkuil
2012-09-03 9:46 ` Prabhakar Lad
2012-09-03 9:25 ` Sylwester Nawrocki [this message]
2012-09-03 9:51 ` Prabhakar Lad
2012-09-03 19:39 ` Sakari Ailus
2012-09-04 5:05 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504477A1.6020304@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hans.verkuil@cisco.com \
--cc=hdegoede@redhat.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=manjunath.hadli@ti.com \
--cc=mchehab@infradead.org \
--cc=prabhakar.lad@ti.com \
--cc=rob@landley.net \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).