From: "Rémi Cardona" <remi.cardona@smartjog.com>
To: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] [media] ds3000: Remove useless 'locking'
Date: Mon, 03 Sep 2012 16:13:42 +0200 [thread overview]
Message-ID: <5044BB16.3000900@smartjog.com> (raw)
In-Reply-To: <1346319391-19015-2-git-send-email-remi.cardona@smartjog.com>
On 08/30/2012 11:36 AM, Rémi Cardona wrote:
> Since b9bf2eafaad9c1ef02fb3db38c74568be601a43a, the function
> ds3000_firmware_ondemand() is called only once during init. This
> locking scheme may have been useful when the firmware was loaded at
> each tune.
>
> Furthermore, it looks like this 'lock' was put in to prevent concurrent
> access (and not recursion as the comments suggest). However, this open-
> coded mechanism is anything but race-free and should have used a proper
> mutex.
>
> Signed-off-by: Rémi Cardona <remi.cardona@smartjog.com>
> ---
> drivers/media/dvb/frontends/ds3000.c | 9 ---------
> 1 file changed, 9 deletions(-)
Ping on that patch. Could anyone take a look at it?
Many thanks,
Rémi
next prev parent reply other threads:[~2012-09-03 14:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 9:36 [PATCH RFC 0/2] ds3000 firmware loading improvements Rémi Cardona
2012-08-30 9:36 ` [PATCH 1/2] [media] ds3000: Remove useless 'locking' Rémi Cardona
2012-09-03 14:13 ` Rémi Cardona [this message]
2012-08-30 9:36 ` [PATCH 2/2] [media] ds3000: properly report firmware loading issues Rémi Cardona
2012-08-30 13:39 ` Antti Palosaari
2012-08-30 15:21 ` Rémi Cardona
2012-08-30 16:00 ` Antti Palosaari
2012-09-03 13:27 ` Rémi Cardona
2012-08-31 8:29 ` Re: [PATCH 2/2] [media] ds3000: properly report firmware loadingissues nibble.max
2012-09-03 14:11 ` Rémi Cardona
2012-09-04 2:19 ` nibble.max
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5044BB16.3000900@smartjog.com \
--to=remi.cardona@smartjog.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).